From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753802Ab1JJLXf (ORCPT ); Mon, 10 Oct 2011 07:23:35 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:49187 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753772Ab1JJLXd (ORCPT ); Mon, 10 Oct 2011 07:23:33 -0400 Date: Mon, 10 Oct 2011 07:23:29 -0400 From: Christoph Hellwig To: Dave Chinner Cc: Sage Weil , Christoph Hellwig , linux-fsdevel@vger.kernel.org, viro@ZenIV.linux.org.uk, ceph-devel@vger.kernel.org, rwheeler@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfs: add d_prune dentry operation Message-ID: <20111010112329.GB28627@infradead.org> References: <1317875170-9349-1-git-send-email-sage@newdream.net> <1317875170-9349-2-git-send-email-sage@newdream.net> <20111006212118.GA24109@infradead.org> <20111010051141.GV3159@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111010051141.GV3159@dastard> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2011 at 04:11:41PM +1100, Dave Chinner wrote: > The code in the patch doesn't explain to me why you'd need to call > dentry_lru_prune() rather than dentry_lru_del()? It's something to > do with the difference between active and inactive LRU removal, but Whenever we actually remove a object it needs to be removed, if it only gets deleted from the LRU because it now has a reference and doesn't belong onto the LRU it doesn't. But yes, this really should be documented better in the code.