From: Christoph Hellwig <hch@lst.de>
To: Richard Weinberger <richard@nod.at>
Cc: Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, xiyou.wangcong@gmail.com,
viro@zeniv.linux.org.uk, dchinner@redhat.com
Subject: Re: [PATCH v2] ramfs: Remove module leftovers
Date: Mon, 10 Oct 2011 13:24:43 +0200 [thread overview]
Message-ID: <20111010112443.GA29093@lst.de> (raw)
In-Reply-To: <4E92D352.1030109@nod.at>
On Mon, Oct 10, 2011 at 01:13:22PM +0200, Richard Weinberger wrote:
> > Removing the dead code looks good, but what is the point in using
> > device_initcall? We've always been using module_init for non-modular
> > code, though.
> >
>
> Ah, ok!
> So we can keep the module_init()?
> I was not sure whether it's valid to use module_init() in pure
> non-modular code...
It is valid. And if it's not the style de jour anymore thousands of people
will flame me now, but I've always done it that way.
prev parent reply other threads:[~2011-10-10 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 10:54 [PATCH v2] ramfs: Remove module leftovers Richard Weinberger
2011-10-10 11:09 ` Christoph Hellwig
2011-10-10 11:13 ` Richard Weinberger
2011-10-10 11:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111010112443.GA29093@lst.de \
--to=hch@lst.de \
--cc=dchinner@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=viro@zeniv.linux.org.uk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox