[PATCH] mfd/db8500-prcmu: convert panic() to pr_crit()

[PATCH] mfd/db8500-prcmu: convert panic() to pr_crit()

[Linus Walleij]

From: Linus Walleij <linus.walleij@linaro.org>

panic() is too heavy for this, indeed the PRCMU is critical for
the system but not to the point that we should stop everything,
if we can still get a prompt or so.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Add-on patch in response to Sam's review comment on liberal
panic() usage.
---
 drivers/mfd/db8500-prcmu.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index e996d11..a25ab9c 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -1763,7 +1763,7 @@ retry:
 
 	if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
 			msecs_to_jiffies(5000))) {
-		panic("prcmu: %s timed out (5 s) waiting for a reply.\n",
+		pr_crit("prcmu: %s timed out (5 s) waiting for a reply.\n",
 			__func__);
 		goto unlock_and_return;
 	}
@@ -1785,7 +1785,7 @@ retry:
 		if (wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
 				msecs_to_jiffies(5000)))
 			goto retry;
-		panic("prcmu: %s timed out (5 s) waiting for AC_SLEEP_ACK.\n",
+		pr_crit("prcmu: %s timed out (5 s) waiting for AC_SLEEP_ACK.\n",
 			__func__);
 	}
 
@@ -1811,7 +1811,7 @@ void prcmu_ac_sleep_req()
 
 	if (!wait_for_completion_timeout(&mb0_transfer.ac_wake_work,
 			msecs_to_jiffies(5000))) {
-		panic("prcmu: %s timed out (5 s) waiting for a reply.\n",
+		pr_crit("prcmu: %s timed out (5 s) waiting for a reply.\n",
 			__func__);
 	}
 
-- 
1.7.3.2

Re: [PATCH] mfd/db8500-prcmu: convert panic() to pr_crit()

[Samuel Ortiz]

Hi Linus,

On Mon, Oct 10, 2011 at 01:04:44PM +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
> 
> panic() is too heavy for this, indeed the PRCMU is critical for
> the system but not to the point that we should stop everything,
> if we can still get a prompt or so.
Thanks, patch applied.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/