From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754802Ab1JKOQg (ORCPT ); Tue, 11 Oct 2011 10:16:36 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:44736 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754767Ab1JKOQe (ORCPT ); Tue, 11 Oct 2011 10:16:34 -0400 Date: Tue, 11 Oct 2011 15:16:31 +0100 From: Dimitris Papastamos To: Mark Brown Cc: Axel Lin , linux-kernel@vger.kernel.org, Liam Girdwood , alsa-devel@alsa-project.org Subject: Re: [PATCH] ASoC: Writing register default value for the reset register Message-ID: <20111011141631.GA5323@opensource.wolfsonmicro.com> References: <1318326900.3526.2.camel@phoenix> <20111011123305.GA2899@opensource.wolfsonmicro.com> <20111011133118.GB3471@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111011133118.GB3471@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 11, 2011 at 02:31:18PM +0100, Mark Brown wrote: > On Tue, Oct 11, 2011 at 01:33:05PM +0100, Dimitris Papastamos wrote: > > On Tue, Oct 11, 2011 at 05:55:00PM +0800, Axel Lin wrote: > > > The WM8983 can be reset by performing a write of any value to > > > the software reset register. > > > > - ret = snd_soc_write(codec, WM8983_SOFTWARE_RESET, 0x8983); > > > + ret = snd_soc_write(codec, WM8983_SOFTWARE_RESET, 0); > > > We should probably just handle the reset register specially during > > resume. > > I really don't think it's worth the code complexity to add special > handling like that, this is a trivial patch which avoids the need for > any extra infrastructure. Aw I thought this code was using the old style open coded syncing functions, which would be trivial and perhaps idiomatic to simply check for the reset register and continue. Thanks, Dimitris