From: Greg KH <greg@kroah.com>
To: Pelle Windestam <pelle@windestam.se>
Cc: Pelle Windestam <iceaway@gmail.com>,
devel@driverdev.osuosl.org, Greg Kroah-Hartman <gregkh@suse.de>,
Jiri Kosina <trivial@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple_strtoul()
Date: Tue, 11 Oct 2011 10:20:23 -0600 [thread overview]
Message-ID: <20111011162023.GA16261@kroah.com> (raw)
In-Reply-To: <CAOdCkm2mtU8v4YrU2-r2aRJOFKruk0mWUV9T67gheykM=74DfQ@mail.gmail.com>
On Tue, Oct 11, 2011 at 12:11:31PM +0200, Pelle Windestam wrote:
> On Tue, Aug 30, 2011 at 8:29 PM, Pelle Windestam <iceaway@gmail.com> wrote:
> > Fixed the checkpatch warning about sing simple_strtoul instead of
> > kstrtoul() in panel.c.
> >
> > Signed-off-by: Pelle Windestam <iceaway@gmail.com>
> > ---
> > drivers/staging/panel/panel.c | 10 ++++------
> > 1 files changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> > index b303b7e..4683d5f 100644
> > --- a/drivers/staging/panel/panel.c
> > +++ b/drivers/staging/panel/panel.c
> > @@ -1179,16 +1179,14 @@ static inline int handle_lcd_special_code(void)
> > break;
> >
> > while (*esc) {
> > - char *endp;
> > -
> > if (*esc == 'x') {
> > esc++;
> > - lcd_addr_x = simple_strtoul(esc, &endp, 10);
> > - esc = endp;
> > + if (kstrtoul(esc, 10, &lcd_addr_x) < 0)
> > + break;
> > } else if (*esc == 'y') {
> > esc++;
> > - lcd_addr_y = simple_strtoul(esc, &endp, 10);
> > - esc = endp;
> > + if (kstrtoul(esc, 10, &lcd_addr_y) < 0)
> > + break;
> > } else
> > break;
> > }
> > --
> > 1.7.3.4
> >
> >
>
> Was there any reason for not accepting this patch?
I don't recall ever seeing it before, care to resend it against the
latest linux-next tree so I can apply it?
thanks,
greg k-h
next prev parent reply other threads:[~2011-10-11 16:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 18:29 [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple_strtoul() Pelle Windestam
2011-10-11 10:11 ` Pelle Windestam
2011-10-11 16:20 ` Greg KH [this message]
2011-10-11 18:36 ` Pelle Windestam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011162023.GA16261@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=iceaway@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pelle@windestam.se \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox