* [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple_strtoul()
@ 2011-08-30 18:29 Pelle Windestam
2011-10-11 10:11 ` Pelle Windestam
0 siblings, 1 reply; 4+ messages in thread
From: Pelle Windestam @ 2011-08-30 18:29 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: devel, linux-kernel, Jiri Kosina, Pelle Windestam
Fixed the checkpatch warning about sing simple_strtoul instead of
kstrtoul() in panel.c.
Signed-off-by: Pelle Windestam <iceaway@gmail.com>
---
drivers/staging/panel/panel.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
index b303b7e..4683d5f 100644
--- a/drivers/staging/panel/panel.c
+++ b/drivers/staging/panel/panel.c
@@ -1179,16 +1179,14 @@ static inline int handle_lcd_special_code(void)
break;
while (*esc) {
- char *endp;
-
if (*esc == 'x') {
esc++;
- lcd_addr_x = simple_strtoul(esc, &endp, 10);
- esc = endp;
+ if (kstrtoul(esc, 10, &lcd_addr_x) < 0)
+ break;
} else if (*esc == 'y') {
esc++;
- lcd_addr_y = simple_strtoul(esc, &endp, 10);
- esc = endp;
+ if (kstrtoul(esc, 10, &lcd_addr_y) < 0)
+ break;
} else
break;
}
--
1.7.3.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple_strtoul()
2011-08-30 18:29 [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple_strtoul() Pelle Windestam
@ 2011-10-11 10:11 ` Pelle Windestam
2011-10-11 16:20 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: Pelle Windestam @ 2011-10-11 10:11 UTC (permalink / raw)
To: Pelle Windestam; +Cc: Greg Kroah-Hartman, devel, linux-kernel, Jiri Kosina
On Tue, Aug 30, 2011 at 8:29 PM, Pelle Windestam <iceaway@gmail.com> wrote:
> Fixed the checkpatch warning about sing simple_strtoul instead of
> kstrtoul() in panel.c.
>
> Signed-off-by: Pelle Windestam <iceaway@gmail.com>
> ---
> drivers/staging/panel/panel.c | 10 ++++------
> 1 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> index b303b7e..4683d5f 100644
> --- a/drivers/staging/panel/panel.c
> +++ b/drivers/staging/panel/panel.c
> @@ -1179,16 +1179,14 @@ static inline int handle_lcd_special_code(void)
> break;
>
> while (*esc) {
> - char *endp;
> -
> if (*esc == 'x') {
> esc++;
> - lcd_addr_x = simple_strtoul(esc, &endp, 10);
> - esc = endp;
> + if (kstrtoul(esc, 10, &lcd_addr_x) < 0)
> + break;
> } else if (*esc == 'y') {
> esc++;
> - lcd_addr_y = simple_strtoul(esc, &endp, 10);
> - esc = endp;
> + if (kstrtoul(esc, 10, &lcd_addr_y) < 0)
> + break;
> } else
> break;
> }
> --
> 1.7.3.4
>
>
Was there any reason for not accepting this patch?
//Pelle
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple_strtoul()
2011-10-11 10:11 ` Pelle Windestam
@ 2011-10-11 16:20 ` Greg KH
2011-10-11 18:36 ` Pelle Windestam
0 siblings, 1 reply; 4+ messages in thread
From: Greg KH @ 2011-10-11 16:20 UTC (permalink / raw)
To: Pelle Windestam
Cc: Pelle Windestam, devel, Greg Kroah-Hartman, Jiri Kosina,
linux-kernel
On Tue, Oct 11, 2011 at 12:11:31PM +0200, Pelle Windestam wrote:
> On Tue, Aug 30, 2011 at 8:29 PM, Pelle Windestam <iceaway@gmail.com> wrote:
> > Fixed the checkpatch warning about sing simple_strtoul instead of
> > kstrtoul() in panel.c.
> >
> > Signed-off-by: Pelle Windestam <iceaway@gmail.com>
> > ---
> > drivers/staging/panel/panel.c | 10 ++++------
> > 1 files changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c
> > index b303b7e..4683d5f 100644
> > --- a/drivers/staging/panel/panel.c
> > +++ b/drivers/staging/panel/panel.c
> > @@ -1179,16 +1179,14 @@ static inline int handle_lcd_special_code(void)
> > break;
> >
> > while (*esc) {
> > - char *endp;
> > -
> > if (*esc == 'x') {
> > esc++;
> > - lcd_addr_x = simple_strtoul(esc, &endp, 10);
> > - esc = endp;
> > + if (kstrtoul(esc, 10, &lcd_addr_x) < 0)
> > + break;
> > } else if (*esc == 'y') {
> > esc++;
> > - lcd_addr_y = simple_strtoul(esc, &endp, 10);
> > - esc = endp;
> > + if (kstrtoul(esc, 10, &lcd_addr_y) < 0)
> > + break;
> > } else
> > break;
> > }
> > --
> > 1.7.3.4
> >
> >
>
> Was there any reason for not accepting this patch?
I don't recall ever seeing it before, care to resend it against the
latest linux-next tree so I can apply it?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple_strtoul()
2011-10-11 16:20 ` Greg KH
@ 2011-10-11 18:36 ` Pelle Windestam
0 siblings, 0 replies; 4+ messages in thread
From: Pelle Windestam @ 2011-10-11 18:36 UTC (permalink / raw)
To: Greg KH
Cc: Pelle Windestam, devel, Greg Kroah-Hartman, Jiri Kosina,
linux-kernel
On Tue, Oct 11, 2011 at 6:20 PM, Greg KH <greg@kroah.com> wrote:
>
> I don't recall ever seeing it before, care to resend it against the
> latest linux-next tree so I can apply it?
>
> thanks,
>
> greg k-h
>
When I checked the linux-next tree again it appears that it has
already been applied, sorry about not noticing that before.
//Pelle
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-11 18:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-30 18:29 [PATCH 1/1] staging: panel: Fixed checkpatch warning about simple_strtoul() Pelle Windestam
2011-10-11 10:11 ` Pelle Windestam
2011-10-11 16:20 ` Greg KH
2011-10-11 18:36 ` Pelle Windestam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox