* [PATCH] ext4/ialloc.c: functions should not be declared extern
@ 2011-09-23 22:19 H Hartley Sweeten
2011-10-12 3:10 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2011-09-23 22:19 UTC (permalink / raw)
To: Linux Kernel; +Cc: linux-ext4, tytso, adilger.kernel
The function declaration in ext4.h is already marked extern. The function
definition should not have the tag.
This quiets the sparse noise:
warning: function 'ext4_init_inode_table' with external linkage has definition
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>
---
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index fd96ea1..ef9bdd6 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -1235,7 +1235,7 @@ unsigned long ext4_count_dirs(struct super_block * sb)
* inode allocation from the current group, so we take alloc_sem lock, to
* block ext4_claim_inode until we are finished.
*/
-extern int ext4_init_inode_table(struct super_block *sb, ext4_group_t group,
+int ext4_init_inode_table(struct super_block *sb, ext4_group_t group,
int barrier)
{
struct ext4_group_info *grp = ext4_get_group_info(sb, group);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4/ialloc.c: functions should not be declared extern
2011-09-23 22:19 [PATCH] ext4/ialloc.c: functions should not be declared extern H Hartley Sweeten
@ 2011-10-12 3:10 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2011-10-12 3:10 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, linux-ext4, adilger.kernel
On Fri, Sep 23, 2011 at 03:19:45PM -0700, H Hartley Sweeten wrote:
> The function declaration in ext4.h is already marked extern. The function
> definition should not have the tag.
>
> This quiets the sparse noise:
>
> warning: function 'ext4_init_inode_table' with external linkage has definition
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-12 3:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-23 22:19 [PATCH] ext4/ialloc.c: functions should not be declared extern H Hartley Sweeten
2011-10-12 3:10 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox