From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752489Ab1JLDKG (ORCPT ); Tue, 11 Oct 2011 23:10:06 -0400 Received: from li9-11.members.linode.com ([67.18.176.11]:60007 "EHLO test.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752450Ab1JLDKD (ORCPT ); Tue, 11 Oct 2011 23:10:03 -0400 Date: Tue, 11 Oct 2011 23:10:01 -0400 From: "Ted Ts'o" To: H Hartley Sweeten Cc: Linux Kernel , linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca Subject: Re: [PATCH] ext4/ialloc.c: functions should not be declared extern Message-ID: <20111012031001.GF11548@thunk.org> Mail-Followup-To: Ted Ts'o , H Hartley Sweeten , Linux Kernel , linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca References: <201109231519.45350.hartleys@visionengravers.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201109231519.45350.hartleys@visionengravers.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on test.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 23, 2011 at 03:19:45PM -0700, H Hartley Sweeten wrote: > The function declaration in ext4.h is already marked extern.  The function > definition should not have the tag. > > This quiets the sparse noise: > > warning: function 'ext4_init_inode_table' with external linkage has definition > > Signed-off-by: H Hartley Sweeten > Cc: "Theodore Ts'o" > Cc: Andreas Dilger Thanks, applied. - Ted