Re: [Patch] Increase USBFS Bulk Transfer size

Mihai Moldovan
2011-10-12T18:06:14Z

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

Hi Greg,

* On 12.10.2011 04:17 PM, Greg KH wrote:
> As stated before, this patch is not acceptable. Please work to figure
> out the real reason for your device problems here, this is not the
> correct solution at all.

I've gone through this whole (and previous) thread, but couldn't find a
real argument why this is so wrong.
So far everybody has argued that it's 'wrong' and may break older user
code. The latter argument even is wrong, as drivers not requiring a
higher bulk transfer size just aren't affected.

This being said, I agree that allocating more memory than needed is
wasting memory and bad, if it can be avoided. On the other hand, we're
talking about very few devices here and not several ten of MB system
memory being wasted by all bulk transfers in total.
I basically see two cases:
- systems with a few MB of RAM. I highly doubt those use usbfs anyway
(usually other stuff like usb-storage)
- systems with 'enough' system memory. In this case the problem is
purely... let's call it 'academic'. You can discuss it lengthly in
theory, but won't even notice it in practice.

Best regards,

Mihai

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4369 bytes --]