From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753293Ab1JLP2j (ORCPT <rfc822;w@1wt.eu>);
	Wed, 12 Oct 2011 11:28:39 -0400
Received: from mail-gx0-f174.google.com ([209.85.161.174]:46317 "EHLO
	mail-gx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751737Ab1JLP2h (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 12 Oct 2011 11:28:37 -0400
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/3] pata_serverworks: use standard cable detection methods
Date: Wed, 12 Oct 2011 17:03:44 +0200
User-Agent: KMail/1.13.6 (Linux/2.6.37.6-0.7-desktop-dirty; KDE/4.6.0; x86_64; ; )
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <201110112009.32126.bzolnier@gmail.com> <20111011204954.2e2280b7@lxorguk.ukuu.org.uk>
In-Reply-To: <20111011204954.2e2280b7@lxorguk.ukuu.org.uk>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201110121704.07439.bzolnier@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Alan Cox wrote:

> On Tue, 11 Oct 2011 20:09:31 +0200
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> 
> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Subject: [PATCH] pata_serverworks: use standard cable detection methods
> 
> You forgot to explain why, or why you want to do this given its
> explicitly contradictory to the supporting documentation.

The patch doesn't change this.  It only makes use of standard cable
helper routines instead of open-coding driver specific ones (the driver
was added before generic cable helpers were available IIRC).