From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753439Ab1JLP24 (ORCPT ); Wed, 12 Oct 2011 11:28:56 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:56871 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753302Ab1JLP2t (ORCPT ); Wed, 12 Oct 2011 11:28:49 -0400 From: Bartlomiej Zolnierkiewicz To: Alan Cox Subject: Re: [PATCH] pata_cs5520: remove incorrect warning message Date: Wed, 12 Oct 2011 17:27:46 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.37.6-0.7-desktop-dirty; KDE/4.6.0; x86_64; ; ) Cc: Jeff Garzik , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <201110112000.44960.bzolnier@gmail.com> <20111011205616.15d0b3b3@lxorguk.ukuu.org.uk> In-Reply-To: <20111011205616.15d0b3b3@lxorguk.ukuu.org.uk> MIME-Version: 1.0 Message-Id: <201110121727.46778.bzolnier@gmail.com> Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alan Cox wrote: > On Tue, 11 Oct 2011 20:00:44 +0200 > Bartlomiej Zolnierkiewicz wrote: > > > From: Bartlomiej Zolnierkiewicz > > Subject: [PATCH] pata_cs5520: remove incorrect warning message > > > > Signed-off-by: Bartlomiej Zolnierkiewicz > > Nothing incorrect about it. It's rather useful information for debugging > CS5520 problems. Users should never see it - and I've not seen it > occuring on any standard VSA releases. > > Do you have any examples of it confusing users or even showing up ? This driver dooen't even use DMA mode so warning about forcing the setting may be puzzling. In addition we do the same thing cs5520_reinit_one() but without warning the user this time. Thus removal of the warning makes it easier for *_reinit_one() replacement by ->init_host method later (patch is ready for this).