* [PATCH] pata_cs5520: remove incorrect warning message
@ 2011-10-11 18:00 Bartlomiej Zolnierkiewicz
2011-10-11 19:56 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2011-10-11 18:00 UTC (permalink / raw)
To: Jeff Garzik; +Cc: linux-ide, linux-kernel
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: [PATCH] pata_cs5520: remove incorrect warning message
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
---
drivers/ata/pata_cs5520.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
Index: b/drivers/ata/pata_cs5520.c
===================================================================
--- a/drivers/ata/pata_cs5520.c
+++ b/drivers/ata/pata_cs5520.c
@@ -148,10 +148,8 @@ static int __devinit cs5520_init_one(str
if (pcicfg & 2)
ppi[1] = π
- if ((pcicfg & 0x40) == 0) {
- dev_warn(&pdev->dev, "DMA mode disabled. Enabling.\n");
+ if ((pcicfg & 0x40) == 0)
pci_write_config_byte(pdev, 0x60, pcicfg | 0x40);
- }
pi.mwdma_mask = id->driver_data;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pata_cs5520: remove incorrect warning message
2011-10-11 18:00 [PATCH] pata_cs5520: remove incorrect warning message Bartlomiej Zolnierkiewicz
@ 2011-10-11 19:56 ` Alan Cox
2011-10-12 15:27 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 4+ messages in thread
From: Alan Cox @ 2011-10-11 19:56 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Jeff Garzik, linux-ide, linux-kernel
On Tue, 11 Oct 2011 20:00:44 +0200
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
> From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> Subject: [PATCH] pata_cs5520: remove incorrect warning message
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Nothing incorrect about it. It's rather useful information for debugging
CS5520 problems. Users should never see it - and I've not seen it
occuring on any standard VSA releases.
Do you have any examples of it confusing users or even showing up ?
Alan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pata_cs5520: remove incorrect warning message
2011-10-11 19:56 ` Alan Cox
@ 2011-10-12 15:27 ` Bartlomiej Zolnierkiewicz
2011-10-12 17:50 ` Alan Cox
0 siblings, 1 reply; 4+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2011-10-12 15:27 UTC (permalink / raw)
To: Alan Cox; +Cc: Jeff Garzik, linux-ide, linux-kernel
Alan Cox wrote:
> On Tue, 11 Oct 2011 20:00:44 +0200
> Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote:
>
> > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
> > Subject: [PATCH] pata_cs5520: remove incorrect warning message
> >
> > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
>
> Nothing incorrect about it. It's rather useful information for debugging
> CS5520 problems. Users should never see it - and I've not seen it
> occuring on any standard VSA releases.
>
> Do you have any examples of it confusing users or even showing up ?
This driver dooen't even use DMA mode so warning about forcing the setting
may be puzzling. In addition we do the same thing cs5520_reinit_one()
but without warning the user this time. Thus removal of the warning makes
it easier for *_reinit_one() replacement by ->init_host method later
(patch is ready for this).
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pata_cs5520: remove incorrect warning message
2011-10-12 15:27 ` Bartlomiej Zolnierkiewicz
@ 2011-10-12 17:50 ` Alan Cox
0 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2011-10-12 17:50 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz; +Cc: Jeff Garzik, linux-ide, linux-kernel
O> This driver dooen't even use DMA mode so warning about forcing the setting
> may be puzzling. In addition we do the same thing cs5520_reinit_one()
> but without warning the user this time. Thus removal of the warning makes
> it easier for *_reinit_one() replacement by ->init_host method later
> (patch is ready for this).
The re-init case won't find it mis-set. And the CS5520 is not a normal
controller even for DMA so I'd prefer it left as is.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-12 17:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-11 18:00 [PATCH] pata_cs5520: remove incorrect warning message Bartlomiej Zolnierkiewicz
2011-10-11 19:56 ` Alan Cox
2011-10-12 15:27 ` Bartlomiej Zolnierkiewicz
2011-10-12 17:50 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox