From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754606Ab1JMKMZ (ORCPT ); Thu, 13 Oct 2011 06:12:25 -0400 Received: from ams-iport-1.cisco.com ([144.254.224.140]:65452 "EHLO ams-iport-1.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754133Ab1JMKMX (ORCPT ); Thu, 13 Oct 2011 06:12:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABe5lk6Q/khM/2dsb2JhbABDqFGBBYFTAQEBBBIBAgEREz8QCxgcEhQYMQsqoS8BgykPAZpwhwxhBId/i3mRXQ X-IronPort-AV: E=Sophos;i="4.69,339,1315180800"; d="scan'208";a="119017620" Date: Thu, 13 Oct 2011 15:42:18 +0530 From: Maneesh Soni To: Ananth N Mavinakayanahalli Cc: ralf@linux-mips.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, david.daney@cavium.com, kamensky@cisco.com Subject: Re: [PATCH] MIPS Kprobes: Support branch instructions probing Message-ID: <20111013101217.GD16761@cisco.com> Reply-To: manesoni@cisco.com References: <20111013090749.GB16761@cisco.com> <20111013094137.GA19054@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111013094137.GA19054@in.ibm.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 13, 2011 at 03:11:38PM +0530, Ananth N Mavinakayanahalli wrote: > On Thu, Oct 13, 2011 at 02:37:49PM +0530, Maneesh Soni wrote: > > ... > > I know nothing of MIPS internals, but... > > > static int __kprobes kprobe_handler(struct pt_regs *regs) > > @@ -239,8 +531,13 @@ static int __kprobes kprobe_handler(struct pt_regs *regs) > > save_previous_kprobe(kcb); > > set_current_kprobe(p, regs, kcb); > > kprobes_inc_nmissed_count(p); > > - prepare_singlestep(p, regs); > > + prepare_singlestep(p, regs, kcb); > > kcb->kprobe_status = KPROBE_REENTER; > > + if (kcb->flags & SKIP_DELAYSLOT) { > > + resume_execution(p, regs, kcb); > > + restore_previous_kprobe(kcb); > > + preempt_enable_no_resched(); > > + } > > return 1; > > } else { > > if (addr->word != breakpoint_insn.word) { > > @@ -284,8 +581,15 @@ static int __kprobes kprobe_handler(struct pt_regs *regs) > > } > > > > ss_probe: > > - prepare_singlestep(p, regs); > > - kcb->kprobe_status = KPROBE_HIT_SS; > > + prepare_singlestep(p, regs, kcb); > > + if (kcb->flags & SKIP_DELAYSLOT) { > > + kcb->kprobe_status = KPROBE_HIT_SSDONE; > > + if (p->post_handler) > > + p->post_handler(p, regs, 0); > > + resume_execution(p, regs, kcb); > > You are missing a preempt_disable_no_resched() here. > ok.. you meant preempt_enable_no_resched(). Will add it in the next version. Thanks for pointing it out. Thanks Maneesh