public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <david.daney@cavium.com>
Cc: manesoni@cisco.com, linux-kernel@vger.kernel.org,
	linux-mips@linux-mips.org, ananth@in.ibm.com, kamensky@cisco.com
Subject: Re: [PATCH] MIPS Kprobes: Support branch instructions probing
Date: Thu, 13 Oct 2011 19:07:14 +0100	[thread overview]
Message-ID: <20111013180714.GA7422@linux-mips.org> (raw)
In-Reply-To: <4E971FD3.2020308@cavium.com>

On Thu, Oct 13, 2011 at 10:28:51AM -0700, David Daney wrote:

> Where is the handling for:
> 
> 	case cop1_op:
> 
> #ifdef CONFIG_CPU_CAVIUM_OCTEON
> 	case lwc2_op: /* This is bbit0 on Octeon */
> 	case ldc2_op: /* This is bbit032 on Octeon */
> 	case swc2_op: /* This is bbit1 on Octeon */
> 	case sdc2_op: /* This is bbit132 on Octeon */
> #endif
> 
> These are all defined in insn_has_delayslot() but not here.

Which is a wonderful demonstration for why duplicating such a large
function from branch.c was a baaad thing to do.

Maneesh, can you refactor the code to share everything that was copied
from __compute_return_epc() can be shared with kprobes?  Idealy make
everything a two part series, first one patch to refactor branch.c and
the 2nd patch to deal with kprobes.

Thanks,

  Ralf

  reply	other threads:[~2011-10-13 18:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13  9:07 [PATCH] MIPS Kprobes: Support branch instructions probing Maneesh Soni
2011-10-13  9:41 ` Ananth N Mavinakayanahalli
2011-10-13 10:12   ` Ananth N Mavinakayanahalli
2011-10-13 10:12   ` Maneesh Soni
2011-10-13 17:28 ` David Daney
2011-10-13 18:07   ` Ralf Baechle [this message]
2011-10-13 19:16     ` Victor Kamensky
2011-10-13 22:59       ` Ralf Baechle
2011-10-14 17:31     ` Maneesh Soni
2011-10-14 17:28   ` Maneesh Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111013180714.GA7422@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=ananth@in.ibm.com \
    --cc=david.daney@cavium.com \
    --cc=kamensky@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=manesoni@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox