From: Ralf Baechle <ralf@linux-mips.org>
To: Victor Kamensky <kamensky@cisco.com>
Cc: David Daney <david.daney@cavium.com>,
manesoni@cisco.com, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, ananth@in.ibm.com
Subject: Re: [PATCH] MIPS Kprobes: Support branch instructions probing
Date: Thu, 13 Oct 2011 23:59:18 +0100 [thread overview]
Message-ID: <20111013225918.GA12513@linux-mips.org> (raw)
In-Reply-To: <Pine.GSO.4.58.1110131205410.7452@infra-view9.cisco.com>
On Thu, Oct 13, 2011 at 12:16:27PM -0700, Victor Kamensky wrote:
> Yes, it does make a lot of sense. Don't you think we need to do
> EXPORT_SYMBOL for __compute_return_epc as well? So it could be used by
> klms.
>
> Actually we have yet another copy of it in mips uprobes code, which
> normally is built as klm, if we refactor and export __compute_return_epc
> all three places could use the same function.
Nothing wrong with exporting __compute_return_epc() as long as there are
actually users of the exported symbol. So far it's only used from the
kernel proper which is why it's not been exported. However I'd prefer it
to be exported as EXPORT_SYMBOL_GPL().
Ralf
next prev parent reply other threads:[~2011-10-13 22:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 9:07 [PATCH] MIPS Kprobes: Support branch instructions probing Maneesh Soni
2011-10-13 9:41 ` Ananth N Mavinakayanahalli
2011-10-13 10:12 ` Ananth N Mavinakayanahalli
2011-10-13 10:12 ` Maneesh Soni
2011-10-13 17:28 ` David Daney
2011-10-13 18:07 ` Ralf Baechle
2011-10-13 19:16 ` Victor Kamensky
2011-10-13 22:59 ` Ralf Baechle [this message]
2011-10-14 17:31 ` Maneesh Soni
2011-10-14 17:28 ` Maneesh Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111013225918.GA12513@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ananth@in.ibm.com \
--cc=david.daney@cavium.com \
--cc=kamensky@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=manesoni@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox