From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/3] x86, intel: Output microcode revision v7
Date: Fri, 14 Oct 2011 09:21:51 +0200 [thread overview]
Message-ID: <20111014072151.GA21913@elte.hu> (raw)
In-Reply-To: <1318546513-2528-1-git-send-email-andi@firstfloor.org>
* Andi Kleen <andi@firstfloor.org> wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> I got a request to make it easier to determine the microcode update level
> on Intel CPUs. This patch adds a new "microcode" field to /proc/cpuinfo.
>
> The microcode level is also outputed on fatal machine checks together
> with the other CPUID model information.
>
> I removed the respective code from the microcode update driver, it
> just reads the field from cpu_data. Also when the microcode is updated
> it fills in the new values too.
>
> I had to add a memory barrier to native_cpuid to prevent it being
> optimized away when the result is not used.
>
> This turns out to clean up further code which already got this
> information manually. This is done in followon patches.
>
> v2: Lots of updates based on feedback.
> v3: Rename cpu_update to microcode. Misc changes from feedback.
> v4: minor updates. rebased.
> v5: move MSR read to early_intel_init()
> v6: Use sync_core() instead of CPUID 1. Drop a white space change.
> v7: Add Acked-bys.
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> Acked-by: H. Peter Anvin <hpa@zytor.com>
> ---
> arch/x86/include/asm/processor.h | 4 +++-
> arch/x86/kernel/cpu/intel.c | 9 +++++++++
> arch/x86/kernel/cpu/mcheck/mce.c | 9 +++++++--
> arch/x86/kernel/cpu/proc.c | 2 ++
> arch/x86/kernel/microcode_intel.c | 14 +++++---------
> 5 files changed, 26 insertions(+), 12 deletions(-)
Applied to tip:x86/microcode,
Thanks,
Ingo
prev parent reply other threads:[~2011-10-14 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 22:55 [PATCH 1/3] x86, intel: Output microcode revision v7 Andi Kleen
2011-10-13 22:55 ` [PATCH 2/3] x86, intel: Use cpu_update for Atom errata check Andi Kleen
2011-10-13 22:55 ` [PATCH 3/3] coretemp: Get microcode revision from cpu_data v3 Andi Kleen
2011-10-14 7:21 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014072151.GA21913@elte.hu \
--to=mingo@elte.hu \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox