From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756789Ab1JNN47 (ORCPT ); Fri, 14 Oct 2011 09:56:59 -0400 Received: from SMTP.ANDREW.CMU.EDU ([128.2.11.61]:37537 "EHLO smtp.andrew.cmu.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754528Ab1JNN45 (ORCPT ); Fri, 14 Oct 2011 09:56:57 -0400 Date: Fri, 14 Oct 2011 09:53:23 -0400 From: Ben Blum To: Frederic Weisbecker Cc: Ben Blum , Tejun Heo , Andrew Morton , Oleg Nesterov , linux-kernel@vger.kernel.org, NeilBrown , paulmck@linux.vnet.ibm.com, Paul Menage , Li Zefan , containers@lists.linux-foundation.org, Balbir Singh , Daisuke Nishimura , KAMEZAWA Hiroyuki Subject: Re: [PATCH 2/2] cgroups: convert ss->attach to use whole threadgroup flex_array (cpuset, memcontrol) Message-ID: <20111014135323.GA3653@ghc17.ghc.andrew.cmu.edu> References: <20110727171101.5e32d8eb@notabene.brown> <20110727150710.GB5242@unix33.andrew.cmu.edu> <20110727234235.GA2318@linux.vnet.ibm.com> <20110728110813.7ff84b13@notabene.brown> <20110728062616.GC15204@unix33.andrew.cmu.edu> <20110728171345.67d3797d@notabene.brown> <20110729142842.GA8462@unix33.andrew.cmu.edu> <20110815184957.GA16588@redhat.com> <20111014003601.GC22527@ghc17.ghc.andrew.cmu.edu> <20111014122126.GL14968@somewhere> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111014122126.GL14968@somewhere> User-Agent: Mutt/1.5.20 (2009-06-14) X-PMX-Version: 5.5.9.388399, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.3.18.170322 X-SMTP-Spam-Clean: 8% ( BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, __BOUNCE_CHALLENGE_SUBJ 0, __BOUNCE_NDR_SUBJ_EXEMPT 0, __CD 0, __CT 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_PATH 0, __URI_NO_WWW 0, __USER_AGENT 0) X-SMTP-Spam-Score: 8% Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 14, 2011 at 02:21:30PM +0200, Frederic Weisbecker wrote: > On Thu, Oct 13, 2011 at 08:36:01PM -0400, Ben Blum wrote: > > Convert ss->attach to take a flex_array of tasks instead of just the leader. > > > > From: Ben Blum > > > > This lets subsystems with whole-threadgroup attach calls (i.e., cpuset and > > memcontrol) to accurately find the group's mm even when a non-leader does exec > > and leaves the leader with a NULL mm pointer. > > > > Also converts cpuset and memcontrol to take the flex_array and iterate down it > > until an mm is found, instead of just attempting to use the leader's mm. > > > > Signed-off-by: Ben Blum > > I think there are patches from Tejun that handle that did that already? > > https://lkml.org/lkml/2011/8/23/418 > Yeah, I'm not hoping to preempt them or anything; I'm just presenting this alternate approach, since (1) this way addresses the ss->attach() problem directly without needing to add locking anywhere else, while the focus of the discussion around Tejun's patches seems to have moved to more global concerns, and (2) these patches and his patches ought to be compatible with each other. Ben