[PATCH 18/21] pci: drop unused Kconfig symbol

[PATCH 18/21] pci: drop unused Kconfig symbol

[Paul Bolle]

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
 drivers/pci/Kconfig |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
index 0fa466a..b42798f 100644
--- a/drivers/pci/Kconfig
+++ b/drivers/pci/Kconfig
@@ -51,17 +51,6 @@ config XEN_PCIDEV_FRONTEND
           The PCI device frontend driver allows the kernel to import arbitrary
           PCI devices from a PCI backend to support PCI driver domains.
 
-config XEN_PCIDEV_FE_DEBUG
-        bool "Xen PCI Frontend debugging"
-        depends on XEN_PCIDEV_FRONTEND && PCI_DEBUG
-	help
-	  Say Y here if you want the Xen PCI frontend to produce a bunch of debug
-	  messages to the system log.  Select this if you are having a
-	  problem with Xen PCI frontend support and want to see more of what is
-	  going on.
-
-	  When in doubt, say N.
-
 config HT_IRQ
 	bool "Interrupts on hypertransport devices"
 	default y
-- 
1.7.4.4

Re: [PATCH 18/21] pci: drop unused Kconfig symbol

[Konrad Rzeszutek Wilk]

On Fri, Oct 14, 2011 at 02:30:39PM +0200, Paul Bolle wrote:
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

Can you provide a commit message describing why?

And can you also use scripts/get_maintainer.pl in the future
to copy the maintainer of this driver as well?

Thanks.
> ---
>  drivers/pci/Kconfig |   11 -----------
>  1 files changed, 0 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index 0fa466a..b42798f 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -51,17 +51,6 @@ config XEN_PCIDEV_FRONTEND
>            The PCI device frontend driver allows the kernel to import arbitrary
>            PCI devices from a PCI backend to support PCI driver domains.
>  
> -config XEN_PCIDEV_FE_DEBUG
> -        bool "Xen PCI Frontend debugging"
> -        depends on XEN_PCIDEV_FRONTEND && PCI_DEBUG
> -	help
> -	  Say Y here if you want the Xen PCI frontend to produce a bunch of debug
> -	  messages to the system log.  Select this if you are having a
> -	  problem with Xen PCI frontend support and want to see more of what is
> -	  going on.
> -
> -	  When in doubt, say N.
> -
>  config HT_IRQ
>  	bool "Interrupts on hypertransport devices"
>  	default y
> -- 
> 1.7.4.4
> 
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 18/21] pci: drop unused Kconfig symbol

[Paul Bolle]

On Fri, 2011-10-14 at 09:57 -0400, Konrad Rzeszutek Wilk wrote:
> Can you provide a commit message describing why?

I'm afraid there's not much more to be said than I did in the summary:
this drops an unused Kconfig symbol. 

> And can you also use scripts/get_maintainer.pl in the future
> to copy the maintainer of this driver as well?

I actually did:
$ git format-patch --stdout -1 ec9f7a5 | scripts/get_maintainer.pl 
Jesse Barnes <jbarnes@virtuousgeek.org> (supporter:PCI SUBSYSTEM)
linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

Perhaps this driver is (some part of) xen. That I didn't check. Should I
have done that too?


Paul Bolle

Re: [PATCH 18/21] pci: drop unused Kconfig symbol

[Paul Bolle]

On Fri, 2011-10-14 at 16:11 +0200, Paul Bolle wrote:
> Perhaps this driver is (some part of) xen. That I didn't check. Should I
> have done that too?

Obviously, since this symbol in unused now, it's not possible to
determine what driver is involved. That would be different if this
Kconfig symbol was actually used previously. But I didn't check - for
all those symbols involved in this series - why they turned out to be
unused now. So I can't say whether these symbols should never have been
in the tree in the first place or whether they were forgotten when
someone removed their last actual usage.


Paul Bolle

Re: [PATCH 18/21] pci: drop unused Kconfig symbol

[Konrad Rzeszutek Wilk]

On Fri, Oct 14, 2011 at 04:11:25PM +0200, Paul Bolle wrote:
> On Fri, 2011-10-14 at 09:57 -0400, Konrad Rzeszutek Wilk wrote:
> > Can you provide a commit message describing why?
> 
> I'm afraid there's not much more to be said than I did in the summary:
> this drops an unused Kconfig symbol. 

Why? Is it b/c PCI_DEBUG does not exist? How did you determine it is
unused?

> 
> > And can you also use scripts/get_maintainer.pl in the future
> > to copy the maintainer of this driver as well?

Driver, not Kconfig.
> 
> I actually did:
> $ git format-patch --stdout -1 ec9f7a5 | scripts/get_maintainer.pl 
> Jesse Barnes <jbarnes@virtuousgeek.org> (supporter:PCI SUBSYSTEM)
> linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM)
> linux-kernel@vger.kernel.org (open list)

konrad@phenom:~/work/linux$ scripts/get_maintainer.pl -f drivers/pci/xen-pcifront.c 
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com> (supporter:XEN HYPERVISOR IN...)
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> (supporter:XEN HYPERVISOR IN...)
Jesse Barnes <jbarnes@virtuousgeek.org> (supporter:PCI SUBSYSTEM)
xen-devel@lists.xensource.com (open list:XEN HYPERVISOR IN...)
virtualization@lists.linux-foundation.org (open list:XEN HYPERVISOR IN...)
linux-pci@vger.kernel.org (open list:PCI SUBSYSTEM)
linux-kernel@vger.kernel.org (open list)

Re: [PATCH 18/21] pci: drop unused Kconfig symbol

[Paul Bolle]

On Fri, 2011-10-14 at 10:22 -0400, Konrad Rzeszutek Wilk wrote:
> Why? Is it b/c PCI_DEBUG does not exist? How did you determine it is
> unused?

$ git grep -n XEN_PCIDEV_FE_DEBUG
$

So there's no other Kconfig symbol that depends in this symbol. Neitehr
is there anything that uses CONFIG_XEN_PCIDEV_FE_DEBUG.


Paul Bolle

Re: [PATCH 18/21] pci: drop unused Kconfig symbol

[Konrad Rzeszutek Wilk]

On Fri, Oct 14, 2011 at 04:22:06PM +0200, Paul Bolle wrote:
> On Fri, 2011-10-14 at 16:11 +0200, Paul Bolle wrote:
> > Perhaps this driver is (some part of) xen. That I didn't check. Should I
> > have done that too?
> 
> Obviously, since this symbol in unused now, it's not possible to
> determine what driver is involved. That would be different if this
> Kconfig symbol was actually used previously. But I didn't check - for

Huh? You can look at what it depends and track that down.

> all those symbols involved in this series - why they turned out to be
> unused now. So I can't say whether these symbols should never have been
> in the tree in the first place or whether they were forgotten when
> someone removed their last actual usage.

I am so confused. So lets start with the foremost question I have:

How did you determine that they were unusued?

Re: [PATCH 18/21] pci: drop unused Kconfig symbol

[Konrad Rzeszutek Wilk]

On Fri, Oct 14, 2011 at 04:30:49PM +0200, Paul Bolle wrote:
> On Fri, 2011-10-14 at 10:22 -0400, Konrad Rzeszutek Wilk wrote:
> > Why? Is it b/c PCI_DEBUG does not exist? How did you determine it is
> > unused?
> 
> $ git grep -n XEN_PCIDEV_FE_DEBUG
> $
> 
> So there's no other Kconfig symbol that depends in this symbol. Neitehr
> is there anything that uses CONFIG_XEN_PCIDEV_FE_DEBUG.

Excellent. Can you include that in the description please then.

And you can also include 'Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>'
on that patch.

Re: [PATCH 18/21] pci: drop unused Kconfig symbol

[Paul Bolle]

On Fri, 2011-10-14 at 10:42 -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Oct 14, 2011 at 04:30:49PM +0200, Paul Bolle wrote:
> > So there's no other Kconfig symbol that depends in this symbol. Neitehr
> > is there anything that uses CONFIG_XEN_PCIDEV_FE_DEBUG.
> 
> Excellent. Can you include that in the description please then.

Sure (minus my typos, of course).

> And you can also include 'Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>'
> on that patch.

Sure. That will be in a week or so. The current plan is to see what gets
NAKed and what gets merged and send the rest (with the tags they
collected in that week) to Michal Marek, who will handle the remaining
patches from there on.


Paul Bolle