From: Andrew Morton <akpm@linux-foundation.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
Thomas Gleixner <tglx@linutronix.de>,
containers@lists.linux-foundation.org,
jacob.jun.pan@linux.intel.com,
Arjan van de Ven <arjan@linux.intel.com>,
linux-kernel@vger.kernel.org, Matt Helsley <matthltc@us.ibm.com>,
linux-api@vger.kernel.org, Kay Sievers <kay.sievers@vrfy.org>,
lennart@poettering.net, harald@redhat.com, david@fubar.dk,
greg@kroah.com
Subject: Re: [PATCH, v10 3/3] cgroups: introduce timer slack controller
Date: Fri, 14 Oct 2011 15:43:48 -0700 [thread overview]
Message-ID: <20111014154348.ae6267aa.akpm@linux-foundation.org> (raw)
In-Reply-To: <1318349729-3108-4-git-send-email-kirill@shutemov.name>
On Tue, 11 Oct 2011 19:15:29 +0300
"Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> Every task_struct has timer_slack_ns value. This value uses to round up
> poll() and select() timeout values. This feature can be useful in
> mobile environment where combined wakeups are desired.
>
> Originally, prctl() was the only way to change timer slack value of
> a process. So you was not able change timer slack value of another
> process.
>
> cgroup subsys "timer_slack" implements timer slack controller. It
> provides a way to set minimal timer slack value for a group of tasks.
> If a task belongs to a cgroup with minimal timer slack value higher than
> task's value, cgroup's value will be applied.
>
> Timer slack controller allows to implement setting timer slack value of
> a process based on a policy. For example, you can create foreground and
> background cgroups and move tasks between them based on system state.
I'm having trouble understanding the value of this feature. Users can
presently control the timer-slack of a group of processes via
inherit-over-fork.
Perhaps there's a case for providing a way for process A to set process
B's slack. And perhaps B's children. That would be a simpler patch
and would have the considerable advantage that it doesn't require
cgroups.
So.... why should we merge this?
next prev parent reply other threads:[~2011-10-14 22:43 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 16:15 [PATCH, v10 0/3] Introduce timer slack controller Kirill A. Shutemov
2011-10-11 16:15 ` [PATCH, v10 1/3] hrtimer: introduce effective timer slack Kirill A. Shutemov
2011-10-11 16:15 ` [PATCH, v10 2/3] hrtimer: implement PR_GET_EFFECTIVE_TIMERSLACK Kirill A. Shutemov
2011-10-11 16:15 ` [PATCH, v10 3/3] cgroups: introduce timer slack controller Kirill A. Shutemov
2011-10-11 16:49 ` Kirill A. Shutemov
2011-10-14 22:43 ` Andrew Morton [this message]
2011-10-14 23:34 ` Kirill A. Shutemov
2011-10-15 11:20 ` Lennart Poettering
2011-10-15 19:11 ` Peter Zijlstra
2011-10-17 1:39 ` Lennart Poettering
2011-10-17 3:22 ` Matthew Garrett
2011-10-17 5:21 ` Arjan van de Ven
2011-10-17 7:36 ` Peter Zijlstra
2011-10-17 9:38 ` Thomas Gleixner
2011-10-17 12:46 ` Matthew Garrett
2011-10-17 13:06 ` Peter Zijlstra
2011-10-17 14:11 ` Matthew Garrett
2011-10-17 14:28 ` Peter Zijlstra
2011-10-17 14:35 ` Arjan van de Ven
2011-10-17 14:45 ` Peter Zijlstra
2011-10-17 14:40 ` Matthew Garrett
2011-10-17 14:49 ` Peter Zijlstra
2011-10-17 14:59 ` Matthew Garrett
2011-10-17 15:11 ` Peter Zijlstra
2011-10-17 15:19 ` Matthew Garrett
2011-10-17 15:21 ` Peter Zijlstra
2011-10-17 15:31 ` Matthew Garrett
2011-10-17 16:36 ` Peter Zijlstra
2011-10-17 16:49 ` Matthew Garrett
2011-10-17 15:48 ` Alan Cox
2011-10-17 16:33 ` Peter Zijlstra
2011-10-17 15:18 ` Peter Zijlstra
2011-10-17 7:34 ` Peter Zijlstra
2011-10-17 13:55 ` Lennart Poettering
2011-10-17 7:28 ` Peter Zijlstra
2011-10-17 19:46 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014154348.ae6267aa.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=containers@lists.linux-foundation.org \
--cc=david@fubar.dk \
--cc=greg@kroah.com \
--cc=harald@redhat.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=kay.sievers@vrfy.org \
--cc=kirill@shutemov.name \
--cc=lennart@poettering.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=matthltc@us.ibm.com \
--cc=menage@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox