From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755339Ab1JNQp1 (ORCPT ); Fri, 14 Oct 2011 12:45:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47702 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755147Ab1JNQpZ (ORCPT ); Fri, 14 Oct 2011 12:45:25 -0400 Date: Fri, 14 Oct 2011 10:40:59 -0600 From: Greg KH To: Jesse Barnes Cc: Neil Horman , Bjorn Helgaas , Stefan Richter , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Matthew Wilcox Subject: Re: [PATCH] sysfs: add per pci device msi[x] irq listing (v5) Message-ID: <20111014164059.GA13951@suse.de> References: <1317307129-11579-1-git-send-email-nhorman@tuxdriver.com> <20110930143211.5ab39c02@stein> <20110930153321.GA31760@hmsreliant.think-freely.org> <20110930165403.GB31760@hmsreliant.think-freely.org> <20111006083607.2c4eb9a5@jbarnes-desktop> <20111006171208.GB22462@hmsreliant.think-freely.org> <20111006180818.GD22462@hmsreliant.think-freely.org> <20111014092148.21158b85@jbarnes-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111014092148.21158b85@jbarnes-desktop> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 14, 2011 at 09:21:48AM -0700, Jesse Barnes wrote: > On Thu, 6 Oct 2011 14:08:18 -0400 > Neil Horman wrote: > > > This patch adds a per-pci-device subdirectory in sysfs called: > > /sys/bus/pci/devices//msi_irqs > > > > This sub-directory exports the set of msi vectors allocated by a given > > pci device, by creating a numbered sub-directory for each vector beneath > > msi_irqs. For each vector various attributes can be exported. Currently the > > only attribute is called mode, which tracks the operational mode of that vector > > (msi vs. msix) > > > > Ok this adds new ABI in the form of sysfs files so I want to make sure > it's ok. > > Matthew has dreams of a more sophisticated MSI-X management scheme, but > it sounds to me like that will mostly affect the driver interfaces and > shouldn't be incompatible with the sysfs scheme you propose here. > > If so, great, we can pull this in and maybe one day someone will > implement better MSI-X support. > > If not, I'd like to hear objections now; Neil has been responsive and > fixed several issues. I don't want to block his patch unless we have > something concrete that it conflicts with. Again, no objection from me at all. greg k-h