Re: [PATCH] sysfs: add per pci device msi[x] irq listing (v4)

Bjorn Helgaas
2011-09-30T16:34:04Z

On Fri, Sep 30, 2011 at 9:33 AM, Neil Horman <nhorman@tuxdriver.com> wrote:
>
> On Fri, Sep 30, 2011 at 02:32:11PM +0200, Stefan Richter wrote:
> > On Sep 29 Neil Horman wrote:
> > > (v4)
> > > Fixed up some spelling mistakes, and added a scissors line with a good
> > > commitlog, so that git-am drops all the version logging
> > >
> > > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> > > CC: Greg Kroah-Hartman <gregkh@suse.de>
> > > CC: Jesse Barnes <jbarnes@virtuousgeek.org>
> > > CC: Bjorn Helgaas <bhelgaas@google.com>
> > > CC: linux-pci@vger.kernel.org
> >
> > It drops these last 5 lines then too, doesn't it?
> >
> I would have thought so, but I tested a git-format-patch / git-am operation here
> on a temporary branch, and it worked properly.
>
> > > --- a/Documentation/ABI/testing/sysfs-bus-pci
> > > +++ b/Documentation/ABI/testing/sysfs-bus-pci
> > > @@ -66,6 +66,24 @@ Description:
> > >             re-discover previously removed devices.
> > >             Depends on CONFIG_HOTPLUG.
> > >
> > > +What:              /sys/bus/pci/devices/.../msi_irqs/
> > > +Date:              September, 2011
> > > +Contact:   Neil Horman <nhorman@tuxdriver.com>
> > > +Description:
> > > +           The /sys/devices/.../msi_irqs directory contains a variable set
> > > +           sub-directories, with each sub-directory being named after a
> > > +           corresponding msi irq vector allocated to that device.
> >
> > "contains a variable set _of_ sub-directories"?
> Gah, bad ispell foo on my part.  Bjorn, can you add that in, or shall I repost?

I'll try to remember to add that in.

Bjorn