Re: [PATCH] sysfs: add per pci device msi[x] irq listing (v2)

Neil Horman
2011-09-16T10:57:23Z

On Fri, Sep 16, 2011 at 10:36:46AM +0200, Greg KH wrote:
> On Thu, Sep 15, 2011 at 04:08:38PM -0400, Neil Horman wrote:
> > +static struct kobj_type msi_irq_ktype = {
> > + .sysfs_ops = &msi_irq_sysfs_ops,
> > + .default_attrs = msi_irq_default_attrs,
> > +};
>
> You still haven't successfully removed the kobject associated with this
> kobj_type. Otherwise you would have seen the error messages in the
> kernel log and fixed up what it told you to fix.
>
> Please do so.
>
Well, I'm not using kobject_del, you're right, I'm just using a kobject_put, and
I swear I'm not getting any error messages about it:
[root@amd-dinar-01 eth0]# echo 1 > ./device/remove
[root@amd-dinar-01 eth0]# dmesg | tasil -10
[ 17.673050] RPC: Registered tcp transport module.
[ 17.677759] RPC: Registered tcp NFSv4.1 backchannel transport module.
[ 17.702913] SELinux: initialized (dev rpc_pipefs, type rpc_pipefs), uses
genfs_contexts
[ 20.060280] bnx2 0000:01:00.0: eth0: NIC Copper Link is Up, 1000 Mbps full
duplex
[ 20.070903] ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
[ 20.106296] bnx2 0000:01:00.1: eth1: NIC Copper Link is Up, 1000 Mbps full
duplex
[ 20.116857] ADDRCONF(NETDEV_CHANGE): eth1: link becomes ready
[ 30.850059] eth1: no IPv6 routers present

I'm not sure why that would be, but theres definately no warning about it.
Either way, I'll gladly make the change to use kobject_del

Regards
Neil