Re: [PATCH] sysfs: add per pci device msi[x] irq listing (v2)

Bjorn Helgaas
2011-09-16T16:12:41Z

[+cc linux-pci@vger.kernel.org]

On Fri, Sep 16, 2011 at 7:32 AM, Neil Horman <nhorman@tuxdriver.com> wrote:
> On Fri, Sep 16, 2011 at 03:23:19PM +0200, Greg KH wrote:
>> On Fri, Sep 16, 2011 at 06:57:16AM -0400, Neil Horman wrote:
>> > On Fri, Sep 16, 2011 at 10:36:46AM +0200, Greg KH wrote:
>> > > On Thu, Sep 15, 2011 at 04:08:38PM -0400, Neil Horman wrote:
>> > > > +static struct kobj_type msi_irq_ktype = {
>> > > > +       .sysfs_ops = &msi_irq_sysfs_ops,
>> > > > +       .default_attrs = msi_irq_default_attrs,
>> > > > +};
>> > >
>> > > You still haven't successfully removed the kobject associated with this
>> > > kobj_type.  Otherwise you would have seen the error messages in the
>> > > kernel log and fixed up what it told you to fix.
>> > >
>> > > Please do so.
>> > >
>> > Well, I'm not using kobject_del, you're right, I'm just using a kobject_put, and
>> > I swear I'm not getting any error messages about it:
>>
>> Then you really are not ever freeing that kobject, so there's a
>> reference counting bug in your code which you need to fix.
>>
>> You will notice the real problem once you try to finally release that
>> kobject, trust me :)
>>
> Ok, copy that, I'll continue to dig, thanks!
> Neil
>
>> greg k-h
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>