From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ashish Chavan <ashish.chavan@kpitcummins.com>
Cc: lrg <lrg@ti.com>, alsa-devel <alsa-devel@alsa-project.org>,
David Dajun Chen <david.chen@diasemi.com>,
"kuninori.morimoto.gx" <kuninori.morimoto.gx@renesas.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH v3 3/8] ASoC: da7210: Add support for line out and DAC
Date: Fri, 14 Oct 2011 20:14:46 +0100 [thread overview]
Message-ID: <20111014191445.GC2931@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1318590245.12107.514.camel@matrix>
On Fri, Oct 14, 2011 at 04:34:05PM +0530, Ashish Chavan wrote:
> + /* Enable Line out amplifiers */
> + snd_soc_write(codec, DA7210_OUT1_L, DA7210_OUT1_L_EN);
> + snd_soc_write(codec, DA7210_OUT1_R, DA7210_OUT1_R_EN);
> + snd_soc_write(codec, DA7210_OUT2, DA7210_OUT2_EN |
> + DA7210_OUT2_OUTMIX_L | DA7210_OUT2_OUTMIX_R);
> +
So, part of the reason I was complaining about you having the DAPM
conversion patch last is that in a driver using DAPM I'd really not
expect to see code like this which open codes register writes to enable
outputs, I'd expect the enables to be being done using DAPM.
parent reply other threads:[~2011-10-14 19:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1318590245.12107.514.camel@matrix>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111014191445.GC2931@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ashish.chavan@kpitcummins.com \
--cc=david.chen@diasemi.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox