* Re: [alsa-devel] [PATCH v3 3/8] ASoC: da7210: Add support for line out and DAC
[not found] <1318590245.12107.514.camel@matrix>
@ 2011-10-14 19:14 ` Mark Brown
0 siblings, 0 replies; only message in thread
From: Mark Brown @ 2011-10-14 19:14 UTC (permalink / raw)
To: Ashish Chavan
Cc: lrg, alsa-devel, David Dajun Chen, kuninori.morimoto.gx,
linux-kernel
On Fri, Oct 14, 2011 at 04:34:05PM +0530, Ashish Chavan wrote:
> + /* Enable Line out amplifiers */
> + snd_soc_write(codec, DA7210_OUT1_L, DA7210_OUT1_L_EN);
> + snd_soc_write(codec, DA7210_OUT1_R, DA7210_OUT1_R_EN);
> + snd_soc_write(codec, DA7210_OUT2, DA7210_OUT2_EN |
> + DA7210_OUT2_OUTMIX_L | DA7210_OUT2_OUTMIX_R);
> +
So, part of the reason I was complaining about you having the DAPM
conversion patch last is that in a driver using DAPM I'd really not
expect to see code like this which open codes register writes to enable
outputs, I'd expect the enables to be being done using DAPM.
^ permalink raw reply [flat|nested] only message in thread