From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Mika Westerberg <mika.westerberg@iki.fi>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
Ryan Mallon <rmallon@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Hartley Sweeten <hsweeten@visionengravers.com>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] mach-ep93xx: break out GPIO driver specifics
Date: Sat, 15 Oct 2011 21:41:30 +0100 [thread overview]
Message-ID: <20111015204129.GZ21648@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20111015181808.GA3128@mwesterb-mobl.ger.corp.intel.com>
On Sat, Oct 15, 2011 at 09:18:08PM +0300, Mika Westerberg wrote:
> I just tried to compile latest linux-next and due to missing <mach/gpio.h> I
> get:
>
> In file included from include/linux/gpio.h:18:0,
> from drivers/gpio/gpiolib.c:10:
> /home/westeri/devel/kernel/linux/arch/arm/include/asm/gpio.h:5:23: fatal error: mach/gpio.h: No such file or directory
> compilation terminated.
> make[2]: *** [drivers/gpio/gpiolib.o] Error 1
>
> It looks like arch/arm/include/asm/gpio.h wants to have <mach/gpio.h>. Any idea
> how to fix this?
Hmm. It shouldn't have been deleted - Linus' patch leaves the file
empty rather than deleting it.
However, as I had to use GNU patch to apply Linus' patch (as git apply
wouldn't because of fuzz), it doesn't understand that, so it removed it.
This is where having an /* empty */ comment avoids that kind of thing,
just like I've done for all the other mach/gpio.h which became empty.
next prev parent reply other threads:[~2011-10-15 20:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 8:42 [PATCH v2] mach-ep93xx: break out GPIO driver specifics Linus Walleij
2011-09-20 17:40 ` Grant Likely
2011-09-20 20:32 ` Linus Walleij
2011-10-01 22:39 ` Russell King - ARM Linux
2011-10-02 21:15 ` Linus Walleij
2011-09-20 17:43 ` H Hartley Sweeten
2011-10-15 18:18 ` Mika Westerberg
2011-10-15 20:41 ` Russell King - ARM Linux [this message]
2011-10-16 7:39 ` Mika Westerberg
2011-10-16 10:57 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111015204129.GZ21648@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=grant.likely@secretlab.ca \
--cc=hsweeten@visionengravers.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@iki.fi \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox