From: Dmitry Torokhov <dtor@vmware.com>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] drivers, vmw_balloon.c: Determine page allocation flag can_sleep outside loop.
Date: Mon, 17 Oct 2011 11:36:06 -0700 [thread overview]
Message-ID: <201110171136.06619.dtor@vmware.com> (raw)
In-Reply-To: <1318875227.10091.5.camel@localhost.localdomain>
On Monday, October 17, 2011 11:13:47 AM Rakib Mullick wrote:
> In vmballoon_reserve_page function, flags has been passed from the
> callee function (vmballoon_inflate here). So, we can determine
> can_sleep outside the loop.
>
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
Thanks Rakib.
Acked-by: Dmitry Torokhov <dtor@vmware.com>
> ---
>
> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
> index 053d36c..6983d80 100644
> --- a/drivers/misc/vmw_balloon.c
> +++ b/drivers/misc/vmw_balloon.c
> @@ -412,6 +412,7 @@ static int vmballoon_reserve_page(struct vmballoon
> *b, bool can_sleep) gfp_t flags;
> unsigned int hv_status;
> bool locked = false;
> + flags = can_sleep ? VMW_PAGE_ALLOC_CANSLEEP : VMW_PAGE_ALLOC_NOSLEEP;
>
> do {
> if (!can_sleep)
> @@ -419,7 +420,6 @@ static int vmballoon_reserve_page(struct vmballoon
> *b, bool can_sleep) else
> STATS_INC(b->stats.sleep_alloc);
>
> - flags = can_sleep ? VMW_PAGE_ALLOC_CANSLEEP :
VMW_PAGE_ALLOC_NOSLEEP;
> page = alloc_page(flags);
> if (!page) {
> if (!can_sleep)
next prev parent reply other threads:[~2011-10-17 18:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 18:13 [PATCH] drivers, vmw_balloon.c: Determine page allocation flag can_sleep outside loop Rakib Mullick
2011-10-17 18:36 ` Dmitry Torokhov [this message]
2011-10-17 19:31 ` David Rientjes
2011-10-17 20:10 ` Rakib Mullick
2011-10-17 20:16 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110171136.06619.dtor@vmware.com \
--to=dtor@vmware.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox