From: Borislav Petkov <bp@alien8.de>
To: Peter Feuerer <peter@piie.net>
Cc: mjg@redhat.com, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 3/3] acerhdf: Lowered default temp fanon/fanoff values
Date: Mon, 17 Oct 2011 14:13:00 +0200 [thread overview]
Message-ID: <20111017121300.GA17411@gere.osrc.amd.com> (raw)
In-Reply-To: <20111016114423.2df6271c.peter@piie.net>
On Sun, Oct 16, 2011 at 11:44:23AM +0200, Peter Feuerer wrote:
> From: Peter Feuerer <peter@piie.net>
>
> Due to new supported hardware, of which the actual temperature limits of
> processor, harddisk and other components are unknown, it feels safer
> with lower fanon / fanoff settings.
>
> It won't change much for most people, already using acerhdf, as they use
> their own fanon/fanoff variable settings when loading the module.
>
> Furthermore seems like kernel and userspace tools have been improved
> to work more efficient and netbooks don't get so hot anymore.
>
> Signed-off-by: Peter Feuerer <peter@piie.net>
> Cc: Borislav Petkov <petkovbb@gmail.com>
> Cc: Matthew Garrett <mjg@redhat.com>
I'm wondering whether the bios_tbl in 2/3 is not growing out of
proportions currently and since a lot of the fields are repeating, it
might make sense to fold its functionality in a switch-case statement.
Maybe in another patch series...
But those patches look ok to me:
Acked-by: Borislav Petkov <bp@alien8.de>
Thanks.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2011-10-17 12:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 21:40 [PATCH 1/2] acerhdf: add support for Aspire 1410 BIOS v1.3314 Peter Feuerer
2011-10-14 21:43 ` [PATCH 2/2] acerhdf: Add support for new hardware Peter Feuerer
2011-10-15 22:32 ` Borislav Petkov
2011-10-15 23:28 ` Peter Feuerer
2011-10-16 8:43 ` Borislav Petkov
2011-10-16 9:38 ` Peter Feuerer
2011-10-16 9:41 ` [PATCH 1/3] acerhdf: add support for Aspire 1410 BIOS v1.3314 Peter Feuerer
2011-10-16 9:42 ` [PATCH 2/3] acerhdf: Add support for new hardware Peter Feuerer
2011-10-16 9:44 ` [PATCH 3/3] acerhdf: Lowered default temp fanon/fanoff values Peter Feuerer
2011-10-17 12:13 ` Borislav Petkov [this message]
2011-11-05 10:58 ` [PATCH RESEND 1/3] acerhdf: add support for Aspire 1410 BIOS v1.3314 Peter Feuerer
2011-11-05 10:59 ` [PATCH RESEND 2/3] acerhdf: Add support for new hardware Peter Feuerer
2011-11-05 11:00 ` [PATCH RESEND 3/3] acerhdf: Lowered default temp fanon/fanoff values Peter Feuerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017121300.GA17411@gere.osrc.amd.com \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=peter@piie.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox