Re: [01/38] PCI: Set PCI-E Max Payload Size on fabric

Bjorn Helgaas
2011-10-11T18:14:34Z

On Tue, Oct 11, 2011 at 11:20 AM, Benjamin LaHaise <bcrl@kvack.org> wrote:
> Hello Greg,
>
> On Tue, Oct 11, 2011 at 10:55:11AM -0600, Greg KH wrote:
>> --- a/drivers/pci/pci.c
>> +++ b/drivers/pci/pci.c
>> @@ -77,6 +77,8 @@ unsigned long pci_cardbus_mem_size = DEF
>>  unsigned long pci_hotplug_io_size  = DEFAULT_HOTPLUG_IO_SIZE;
>>  unsigned long pci_hotplug_mem_size = DEFAULT_HOTPLUG_MEM_SIZE;
>>
>> +enum pcie_bus_config_types pcie_bus_config = PCIE_BUS_PERFORMANCE;
>> +
>
> This version of the patch incorrectly defaults to the new performance
> mode.  Since we haven't even had that code in the 3.1 release yet, I don't
> think it is suitable for a stable release.  This patch should be revised
> to a version with default set to safe/don't-touch mode if it is to be
> included.

It's not obvious that this fits the criteria for -stable
(Documentation/stable_kernel_rules.txt).

For example, I can't tell what real problem this fixes.