Re: [01/38] PCI: Set PCI-E Max Payload Size on fabric

Greg KH
2011-10-11T19:25:08Z

On Tue, Oct 11, 2011 at 12:14:05PM -0600, Bjorn Helgaas wrote:
> On Tue, Oct 11, 2011 at 11:20 AM, Benjamin LaHaise <bcrl@kvack.org> wrote:
> > Hello Greg,
> >
> > On Tue, Oct 11, 2011 at 10:55:11AM -0600, Greg KH wrote:
> >> --- a/drivers/pci/pci.c
> >> +++ b/drivers/pci/pci.c
> >> @@ -77,6 +77,8 @@ unsigned long pci_cardbus_mem_size = DEF
> >>  unsigned long pci_hotplug_io_size  = DEFAULT_HOTPLUG_IO_SIZE;
> >>  unsigned long pci_hotplug_mem_size = DEFAULT_HOTPLUG_MEM_SIZE;
> >>
> >> +enum pcie_bus_config_types pcie_bus_config = PCIE_BUS_PERFORMANCE;
> >> +
> >
> > This version of the patch incorrectly defaults to the new performance
> > mode.  Since we haven't even had that code in the 3.1 release yet, I don't
> > think it is suitable for a stable release.  This patch should be revised
> > to a version with default set to safe/don't-touch mode if it is to be
> > included.

Wait, I thought a patch farther in the series made it off by default,
yes, see patch 6 in this series for that one.

> It's not obvious that this fits the criteria for -stable
> (Documentation/stable_kernel_rules.txt).
>
> For example, I can't tell what real problem this fixes.

Yeah, it's not obvious, but I have had a lot of reports that 3.0 does
not work on some systems without this set of patches. Now figuring out
of those same systems ever worked at all is getting to be quite
difficult as I don't have access to the hardware, and the people that do
aren't responding to test requests. But from what I gather, 2.6.32 did
work on these boxes, so it is a regression somehow, but I am not
positive of this.

Because of that, I've included these patches. They default to off now,
but allow machines that were oopsing on bootup, to now work properly,
which is resolving regressions, so that would seem to meet stable
critera, right?

Now I'm very open to pushback, and if people really don't want these in
(i.e. the PCI maintainer(s) say no), then I'll drop them and work with
the distros to get them into their trees so that their customers's
systems will work properly.

thanks,

greg k-h