From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756453Ab1JQQWU (ORCPT ); Mon, 17 Oct 2011 12:22:20 -0400 Received: from out5.smtp.messagingengine.com ([66.111.4.29]:34450 "EHLO out5.smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818Ab1JQQWS (ORCPT ); Mon, 17 Oct 2011 12:22:18 -0400 X-Sasl-enc: u+Pjq7btrDOUnbHjYgIAgfz7pFoqazC607f6EnKk5gbK 1318868537 Date: Mon, 17 Oct 2011 09:22:08 -0700 From: Greg KH To: "Kasatkin, Dmitry" Cc: James Morris , linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, zohar@linux.vnet.ibm.com, dhowells@redhat.com, herbert@gondor.hengli.com.au Subject: Re: [PATCH v2.1 1/7] crypto: GnuPG based MPI lib - source files (part 1) Message-ID: <20111017162208.GA6661@kroah.com> References: <92d93a9fe52e048a21d19732c31d80c9ec44de77.1318598705.git.dmitry.kasatkin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 17, 2011 at 12:11:37PM +0300, Kasatkin, Dmitry wrote: > >From Kernel Docbook > > Similar to EXPORT_SYMBOL() except that the > symbols exported by EXPORT_SYMBOL_GPL() can > only be seen by modules with a > MODULE_LICENSE() that specifies a GPL > compatible license. It implies that the function is considered > an internal implementation issue, and not really an interface. > > "not really an interface".... > > Should it really be EXPORT_SYMBOL_GPL? Yes.