Re: [PATCH, v10 3/3] cgroups: introduce timer slack controller

Peter Zijlstra
2011-10-17T13:06:52Z

On Mon, 2011-10-17 at 13:46 +0100, Matthew Garrett wrote:
> On Mon, Oct 17, 2011 at 11:38:03AM +0200, Thomas Gleixner wrote:
>
> > Unfortunately this is a full speed rolling trainwreck already. The
> > whole app space is made to encourage shitty applications. Android is
> > designed exactly in that way and it seems that all other desktop folks
> > have fully adopted that adsurdity.
> >
> > Back when NOHZ was merged in the kernel, powertop made people fix crap
> > left and right in not time. Why should we add something which actively
> > fosters crappy applications today?
>
> They're orthogonal. Sometimes you want timer-driven behaviour (how else
> are you going to draw animations?) and that's obviously going to
> generate wakeups. This is for the idle case, where the user is no longer
> sitting in front of the machine but you don't want to trigger a full
> system suspend. We either need every application that ever uses
> timer-driven behaviour to support setting its own timer slack on some
> sort of external policy decision, or we need a way to let the kernel
> force them to.

No!! you want that application to stop drawing stuff that is invisible.
Setting your own timerslack for something you know is pointless is worse
than doing something pointless, its down right stupid.

Please, work with the X folks and make it an error to draw to invisible
surfaces. And yes, I know that composition makes that a non-trivial
problem. But at least the blank screen case should be trivial, and I
suspect there's more tractable cases as well. Mostly the desktop is
still a very static place and a few extra timer ticks for when you're
spinning your desktop cube around isn't going to be a problem.