From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Cc: linux-kernel@vger.kernel.org, Grant Likely <grant.likely@secretlab.ca>
Subject: re: gpio-ml-ioh: Support interrupt function
Date: Mon, 17 Oct 2011 23:10:58 +0300 [thread overview]
Message-ID: <20111017201058.GA13916@elgon.mountain> (raw)
Hi,
The linux-next patch 54be566317b6 "gpio-ml-ioh: Support interrupt
function" generates a Sparse warning.
+ irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
+ GFP_KERNEL);
^^^^^^^^^^
The last argument should be a NUMA node, not a GFP_ flag. I'm not
sure what the right fix is. There are currently 5 callers in my
cscope for this function in linux-next.
2 pass GFP_KERNEL which is wrong.
2 pass 0 which maybe should be cpu_to_node(0)?
1 passes -1 which maybe could be NUMA_NO_NODE?
I'm probably embarrassing myself with my ignorance here, but I do
know that GFP_KERNEL isn't right.
regards,
dan carpenter
next reply other threads:[~2011-10-17 20:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 20:10 Dan Carpenter [this message]
2011-10-18 0:32 ` gpio-ml-ioh: Support interrupt function Tomoya MORINAGA
2011-10-18 5:56 ` David Rientjes
2011-10-18 6:38 ` Tomoya MORINAGA
2011-10-18 6:52 ` David Rientjes
2011-10-18 7:03 ` Tomoya MORINAGA
2011-10-18 12:12 ` Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017201058.GA13916@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=tomoya-linux@dsn.okisemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox