Re: [alsa-devel] [PATCH v4 3/7] ASoC: da7210: Add support for mute and zero cross controls

Re: [alsa-devel] [PATCH v4 3/7] ASoC: da7210: Add support for mute and zero cross controls

[Mark Brown]

On Sat, Oct 15, 2011 at 02:53:15PM +0530, Ashish Chavan wrote:

> +	SOC_SINGLE("ADC Left Capture Switch", DA7210_ADC, 2, 1, 0),
> +	SOC_SINGLE("ADC Right Capture Switch", DA7210_ADC, 6, 1, 0),

I'd really expect this to be a single stereo control.

Re: [alsa-devel] [PATCH v4 3/7] ASoC: da7210: Add support for mute and zero cross controls

[Mark Brown]

On Tue, Oct 18, 2011 at 05:19:08PM +0530, Ashish Chavan wrote:

> 	SOC_DOUBLE_R("Mic Capture Switch", ...),
> 	SOC_SINGLE("Aux2 Capture Switch", ...),

> Now I have realized that this may cause a naming conflict with my
> "mic_aux_inpga" patch, which I am going to submit after DAPM issues get
> sorted. In "mic aux inpga" patch there are controls for Mic and Aux2
> volume control,

> 	SOC_DOUBLE_R_TLV("Mic Capture Volume", ...),
> 	SOC_SINGLE_TLV("Aux2 Capture Volume", ...),

> As per my view, "Mic Capture Volume" is correct name for Mic volume
> control and we need to change name for Mic mute control. Do you agree?
> If yes, any suggestion for the name of Mic mute control?

I don't see any conflict in the above?

Re: [alsa-devel] [PATCH v4 3/7] ASoC: da7210: Add support for mute and zero cross controls

[Mark Brown]

On Tue, Oct 18, 2011 at 05:59:03PM +0530, Ashish Chavan wrote:
> On Tue, 2011-10-18 at 13:08 +0100, Mark Brown wrote:
> > On Tue, Oct 18, 2011 at 05:19:08PM +0530, Ashish Chavan wrote:

> > > 	SOC_DOUBLE_R("Mic Capture Switch", ...),
> > > 	SOC_SINGLE("Aux2 Capture Switch", ...),

> > > 	SOC_DOUBLE_R_TLV("Mic Capture Volume", ...),
> > > 	SOC_SINGLE_TLV("Aux2 Capture Volume", ...),

> > I don't see any conflict in the above?

> If I add these two, alsamixer and amixer shows only one of them (one
> which is added first). Is that fine?

Eh?  One is a Volume, the other is a Switch.  Note that alsamixer does
render the two stacked on top of each other in the UI.

Re: [alsa-devel] [PATCH v4 3/7] ASoC: da7210: Add support for mute and zero cross controls

[Mark Brown]

On Tue, Oct 18, 2011 at 06:30:28PM +0530, Ashish Chavan wrote:

> > Eh?  One is a Volume, the other is a Switch.  Note that alsamixer does
> > render the two stacked on top of each other in the UI.

> Yes, I guessed that earlier. Anyways I generally don't rely on alsamixer
> and use amixer whereever possible. In amixer also, it shows only one
> control, the one that I add first. If I change "Mic" to some thing else
> like "MicM" or "Mic Mute", then it shows both controls.

Check again, amixer also merges controls.

> BTW does amixer version have any significance here? I know my alsa-utils
> are quite old (1.0.14)

That's spectacularly old, I guess it's possible it's buggy.