From: Ingo Molnar <mingo@elte.hu>
To: Robert Richter <robert.richter@amd.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
oprofile-list <oprofile-list@lists.sourceforge.net>,
stable@kernel.org
Subject: Re: [PATCH 2/5] oprofile: Fix crash when unloading module (hr timer
Date: Tue, 18 Oct 2011 08:12:26 +0200 [thread overview]
Message-ID: <20111018061226.GC16304@elte.hu> (raw)
In-Reply-To: <1318861624-715-3-git-send-email-robert.richter@amd.com>
* Robert Richter <robert.richter@amd.com> wrote:
> + /* failed */
> + if (timer_mode)
> + oprofile_timer_exit();
> + else
> + oprofile_arch_exit();
> - oprofile_arch_exit();
> + if (timer_mode)
> + oprofile_timer_exit();
> + else
> + oprofile_arch_exit();
That's rather ugly ...
Thanks,
Ingo
next prev parent reply other threads:[~2011-10-18 6:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 14:26 [PATCH 0/5] oprofile: Updates and fixes for timer modes Robert Richter
2011-10-17 14:27 ` [PATCH 1/5] oprofile, x86: Add kernel parameter Robert Richter
2011-10-17 14:27 ` [PATCH 2/5] oprofile: Fix crash when unloading module (hr timer Robert Richter
2011-10-18 6:12 ` Ingo Molnar [this message]
2011-10-17 14:27 ` [PATCH 3/5] oprofile, x86: Fix crash when unloading module (nmi Robert Richter
2011-10-17 14:27 ` [PATCH 4/5] oprofile: Remove exit function for timer mode Robert Richter
2011-10-18 6:13 ` Ingo Molnar
2011-10-19 16:33 ` Robert Richter
2011-10-17 14:27 ` [PATCH 5/5] oprofile, x86: Reimplement nmi timer mode using perf Robert Richter
2011-10-18 10:59 ` Peter Zijlstra
2011-10-19 16:52 ` Robert Richter
2011-10-19 18:07 ` [PATCH 4/5] oprofile: Remove exit function for timer mode Robert Richter
2011-10-17 15:22 ` [PATCH 0/5] oprofile: Updates and fixes for timer modes Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111018061226.GC16304@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sourceforge.net \
--cc=robert.richter@amd.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox