From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595Ab1JRXvj (ORCPT ); Tue, 18 Oct 2011 19:51:39 -0400 Received: from mail-yx0-f174.google.com ([209.85.213.174]:38185 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017Ab1JRXvi (ORCPT ); Tue, 18 Oct 2011 19:51:38 -0400 Date: Tue, 18 Oct 2011 21:51:33 -0200 From: Arnaldo Carvalho de Melo To: David Ahern Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Frederic Weisbecker , Mike Galbraith , Paul Mackerras , Peter Zijlstra , Stephane Eranian Subject: Re: [PATCH 6/7] perf ui browser: Make the colors configurable and change the defaults Message-ID: <20111018235133.GA3494@ghostprotocols.net> References: <1318974247-6683-1-git-send-email-acme@infradead.org> <1318974247-6683-7-git-send-email-acme@infradead.org> <4E9E082D.8040403@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E9E082D.8040403@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Oct 18, 2011 at 05:13:49PM -0600, David Ahern escreveu: > > + { > > + .colorset = HE_COLORSET_MEDIUM, > > + .name = "medium", > > + .fg = "green", > > + .bg = "black", > > + }, > > + { > > + .colorset = HE_COLORSET_NORMAL, > > + .name = "normal", > > + .fg = "brightgreen", > > + .bg = "black", > > + }, > Using gnome3 with Fedora 15 these last 2 color sets don't look so good. > The 'black' background is not really black - more of a gray'ish look and > the green font does not show up well. Yes, I get that they are > configurable, but the defaults should be readable too. I'm trying to get there :) Yeah, I also noticed that libslang's "black" is kinda like a bright black, really strange, I need to figure this out and also how to get the colors currently set in the terminal to get this finally like --stdio. I.e. the defaults should be what are on the xterm, like --stdio. - Arnaldo