From: Wolfram Sang <w.sang@pengutronix.de>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: David Rientjes <rientjes@google.com>,
Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch WARNING: patch prefix 'b' exists, appears to be a -p0 patch
Date: Wed, 19 Oct 2011 12:26:30 +0200 [thread overview]
Message-ID: <20111019102630.GE3217@pengutronix.de> (raw)
In-Reply-To: <4E9E89F2.2060103@cam.ac.uk>
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
> Sorry, I missed one detail. This warning is firing on every patch including
> any I pull off mailing lists or produce with git format-patch
So, I assume you have a directory named 'b' in the kernel-root-dir?
The p1-detection is heuristic and can always be fooled, so I don't think
extending the logic will help. If too many users think it is annoying,
it may be better to remove it. I do think, however, that it might help
users sending in their first patches, so I'd prefer to keep it.
Experienced users have the option to use something like "--ignore
PATCH_PREFIX" in their .checkpatch.conf. I vote for improving the error
message but won't oppose a removal if that is what is wanted.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-10-19 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 15:03 checkpatch WARNING: patch prefix 'b' exists, appears to be a -p0 patch Jonathan Cameron
2011-10-18 23:44 ` David Rientjes
2011-10-19 0:01 ` Joe Perches
2011-10-19 1:27 ` David Rientjes
2011-10-19 8:27 ` Jonathan Cameron
2011-10-19 10:26 ` Wolfram Sang [this message]
2011-10-19 11:04 ` Jonathan Cameron
2011-10-19 11:22 ` Wolfram Sang
2011-10-19 11:32 ` Jonathan Cameron
2011-10-19 16:17 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111019102630.GE3217@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=apw@canonical.com \
--cc=jic23@cam.ac.uk \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).