From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756937Ab1JSRQ6 (ORCPT ); Wed, 19 Oct 2011 13:16:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45243 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755669Ab1JSRQ4 (ORCPT ); Wed, 19 Oct 2011 13:16:56 -0400 Date: Wed, 19 Oct 2011 15:16:00 -0200 From: Flavio Leitner To: David Miller Cc: dpmcgee@gmail.com, netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Disable TCP_DEBUG and FASTRETRANS_DEBUG by default Message-ID: <20111019151600.67cd99e6@asterix.rh> In-Reply-To: <20111017.175238.18474279385644215.davem@davemloft.net> References: <1318883125-29500-1-git-send-email-dpmcgee@gmail.com> <20111017.175238.18474279385644215.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 17 Oct 2011 17:52:38 -0400 (EDT) David Miller wrote: > From: Dan McGee > Date: Mon, 17 Oct 2011 15:25:24 -0500 > > > If these are truly debug options, they should be turned off by default > > and can be tweaked if necessary. Fix one usage of the flag to use #if > > instead of #ifdef so defining to zero is acceptable. > > > > Signed-off-by: Dan McGee > > Illegal window shrinks are a serious issue, and the fact that everyone > will see those messages by default and sometimes report them has been > tremendously useful. > Agreed. I recently got bug report because of that message. It is useful and doesn't disturbe when network is fine, so please don't remove it. fbl