Re: [PATCH 5/5] oprofile, x86: Reimplement nmi timer mode using perf

Robert Richter
2011-10-19T16:53:48Z

On 18.10.11 06:59:41, Peter Zijlstra wrote:
> On Mon, 2011-10-17 at 16:27 +0200, Robert Richter wrote:
> > The legacy x86 nmi watchdog code was removed with the implementation
> > of the perf based nmi watchdog. This broke Oprofile's nmi timer
> > mode. To run nmi timer mode we relied on a continuous ticking nmi
> > source which the nmi watchdog provided. The nmi tick was no longer
> > available and current watchdog can not be used anymore since it runs
> > with very long periods in the range of seconds. This patch
> > reimplements the nmi timer mode using a perf counter nmi source.
>
> fair enough,
>
> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
>
> I take it you'll take this through your oprofile tree?

Yes, will send it through my tree.

Thanks,

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center