Re: [alsa-devel] [PATCH v6 2/2] ASoC: da7210: Add support for ALC and Noise suppression

Re: [alsa-devel] [PATCH v6 2/2] ASoC: da7210: Add support for ALC and Noise suppression

[Girdwood, Liam]

On 19 October 2011 09:54, Ashish Chavan <ashish.chavan@kpitcummins.com> wrote:
> This patch adds controls to set following ALC parameters,
>  - Max gain, Min gain, Noise gain, Attack rate, Release rate and delay
>
> It also adds a switch to enable/disable noise suppression.
>
> As per DA7210 data sheet, ALC and noise suppression can be enabled
> only if certain conditions are met. This condition checks are handled
> by simply using "_EXT" version of controls to capture change events.
>
> Signed-off-by: Ashish Chavan <ashish.chavan@kpitcummins.com>
> Signed-off-by: David Dajun Chen <dchen@diasemi.com>
> ---
> Changes since v5:
> - Changed error code from -EPERM to EINVAL
> - Used bit fields instead of magic numbers
>
> Changes since v1:
> - Reading from register instead of cache
> - Made debug message more specific about error
> - Changed "Gain" to "Volume" in names of ALC controls
> ---
>  sound/soc/codecs/da7210.c |  110 +++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 110 insertions(+), 0 deletions(-)
>

Acked-by: Liam Girdwood <lrg@ti.com>

Thanks

Liam

Re: [alsa-devel] [PATCH v6 2/2] ASoC: da7210: Add support for ALC and Noise suppression

[Mark Brown]

On Wed, Oct 19, 2011 at 02:24:37PM +0530, Ashish Chavan wrote:
> This patch adds controls to set following ALC parameters,
>  - Max gain, Min gain, Noise gain, Attack rate, Release rate and delay

Applied, thanks.