From: David Miller <davem@davemloft.net>
To: cloud.ren@Atheros.com
Cc: Luis.Rodriguez@Atheros.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch net-next]alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver
Date: Thu, 20 Oct 2011 04:45:41 -0400 (EDT) [thread overview]
Message-ID: <20111020.044541.970282389722164761.davem@davemloft.net> (raw)
In-Reply-To: <1319093184-19696-1-git-send-email-cloud.ren@Atheros.com>
From: <cloud.ren@Atheros.com>
Date: Thu, 20 Oct 2011 14:46:24 +0800
> +#define __far
So much unused crap left in these header files, get rid of this stuff.
+#define ALX_HW_WARN(_fmt, _args...) \
+ ALX_HW_PRINTA(WARNING, _fmt, ## _args)
+
+#define ALX_HW_INFO(_fmt, _args...) \
+ ALX_HW_PRINTA(INFO, _fmt, ## _args)
+
+#define ALX_HW_DBG(_fmt, _args...) \
+ ALX_HW_PRINTA(DEBUG, _fmt, ## _args)
+
We told you to get rid of your customized debug logging interfaces,
yet all of this stuff is still there.
+/* delay function */
+#define US_DELAY(_hw, _n) __US_DELAY(_n)
+#define MS_DELAY(_hw, _n) __MS_DELAY(_n)
+#define __US_DELAY(_n) udelay(_n)
+#define __MS_DELAY(_n) mdelay(_n)
Useless wrappers for standard kernel interfaces, kill this.
+#define DEBUG_INFO(_a, _b)
+#define DEBUG_INFOS(_a, _b)
Again we told you to get rid of this stuff.
I suspect it's going to take may rounds of feedback before this driver
is anywhere near ready for inclusion.
Please just submit it to staging and let it cook there for a couple
weeks in the interests of our sanity.
next prev parent reply other threads:[~2011-10-20 8:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 6:46 [patch net-next]alx: Atheros AR8131/AR8151/AR8152/AR8161 Ethernet driver cloud.ren
2011-10-20 8:45 ` David Miller [this message]
2011-10-20 9:00 ` Joe Perches
2011-10-20 9:23 ` Ren, Cloud
2011-10-20 9:25 ` David Miller
2011-10-20 9:48 ` Ren, Cloud
2011-10-20 20:33 ` Luis R. Rodriguez
2011-10-21 2:21 ` Ren, Cloud
2011-10-21 2:36 ` Luis R. Rodriguez
-- strict thread matches above, loose matches on Subject: below --
2011-10-19 7:26 cloud.ren
2011-10-19 7:33 ` David Miller
2011-10-19 7:44 ` Ren, Cloud
2011-10-19 7:50 ` David Miller
2011-10-19 7:53 ` Ren, Cloud
2011-10-19 7:56 ` Joe Perches
2011-10-19 22:21 ` Francois Romieu
2011-10-19 22:59 ` Joe Perches
2011-10-20 7:29 ` Ren, Cloud
2011-10-20 8:48 ` David Miller
2011-10-28 2:56 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111020.044541.970282389722164761.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Luis.Rodriguez@Atheros.com \
--cc=cloud.ren@Atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox