Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM

Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM

[Girdwood, Liam]

On 20 October 2011 15:02, Ashish Chavan <ashish.chavan@kpitcummins.com> wrote:
> This patch adds support for DAPM covering all inputs and outputs
> as well as ADC and DAC.
>
> Signed-off-by: Ashish Chavan <ashish.chavan@kpitcummins.com>
> Signed-off-by: David Dajun Chen <dchen@diasemi.com>
> ---
> Changes since v3:
> - Added missing routes for In-mixer left and right
> - Added comment explaining rational behind use of STANDBY registers
>
> Changes since v1:
> - used supply widget for mic bias
> - removed mic bias hookup
> - assigned dapm widgets and routes in card struct
> - removed explicit setting of default mixer settings
> - removed explicit setting of ios to standby mode
> ---
>  sound/soc/codecs/da7210.c |  240 ++++++++++++++++++++++++++++++++++++++++-----
>  1 files changed, 216 insertions(+), 24 deletions(-)
>

Acked-by: Liam Girdwood <lrg@ti.com>

Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM

[Mark Brown]

On Thu, Oct 20, 2011 at 07:32:49PM +0530, Ashish Chavan wrote:
> This patch adds support for DAPM covering all inputs and outputs
> as well as ADC and DAC.

This patch doesn't apply against current code.

> +/*
> + * DAPM Controls
> + *
> + * Current DAPM implementation covers almost all codec components e.g. IOs,
> + * mixers, PGAs,ADC and DAC.

This explanation would better placed next to the code in the probe -
it's that code which looks out of place in a Linux driver.

Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM

[Mark Brown]

On Fri, Oct 21, 2011 at 03:17:26PM +0530, Ashish Chavan wrote:
> On Fri, 2011-10-21 at 09:58 +0100, Mark Brown wrote:

> > This explanation would better placed next to the code in the probe -
> > it's that code which looks out of place in a Linux driver.

> Only problem with that is the code to enable individual IOs is not at
> one place and is scattered in the probe(). Should I place all such
> things in a single block in probe() and put the comment above that?

That sounds like a good idea - it's fine to split them up per feature
being enabled but if the big comment is in front of all of them that'd
be really helpful.

Re: [alsa-devel] [PATCH v7 1/3] ASoC: da7210: Add support for DAPM

[Mark Brown]

On Fri, Oct 21, 2011 at 04:07:21PM +0530, Ashish Chavan wrote:

> Is there web interface to your tree? so that I can introspect your
> version of da7210.c file to find out what is going wrong? Or any other
> way to get your version of that file?

http://opensource.wolfsonmicro.com/cgi-bin/gitweb.cgi