Re: [patch 5/5] elf: Add support for loading ET_CKPT files

[Tejun Heo <tj@kernel.org>]

Hello,

On Fri, Oct 21, 2011 at 10:42:39PM +0400, Cyrill Gorcunov wrote:
> On Fri, Oct 21, 2011 at 10:36:28PM +0400, Cyrill Gorcunov wrote:
> > > I think this comes back to why one-stop-solution-in-kernel is a bad
> > > idea for CR.  My impression is that when people say "that would
> > > require too many small API updatesa", it usually means that they
> > > haven't really thought about each necessary piece enough and just
> 
> Don't claim such things, Tejun. Yes, I'm missing a number of things
> (the same applies to you as well), but this patch was not 'just a
> fast way to achieve what we need'. It's rather an attempt to gather
> all things I've missed and provide more robust/solid version at the
> next iteration (regargless which form this patch appeared, complete
> user-space solution, some kernel api extension of whatever).

Hmmm... my point was that single lumpy implementation allows for such
mistakes to go unnoticed && makes it difficult to recover and thus is
a bad approach to the problem.  For example, unlikely but, let's say
we missed this vdso thing and it went into upstream, now what would we
do?  We'll need to somehow allow userland supply vdso symtab to kernel
and let the kernel do the bridging and then probably bump the version
number for elf format and so on.  IMHO, that just isn't a good way to
approach the problem, so let's please do it piece by piece.

Thanks.

-- 
tejun