From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751915Ab1JUSsY (ORCPT ); Fri, 21 Oct 2011 14:48:24 -0400 Received: from mail-iy0-f174.google.com ([209.85.210.174]:57693 "EHLO mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751626Ab1JUSsX (ORCPT ); Fri, 21 Oct 2011 14:48:23 -0400 Date: Fri, 21 Oct 2011 11:48:17 -0700 From: Tejun Heo To: Cyrill Gorcunov Cc: Pavel Emelyanov , "linux-kernel@vger.kernel.org" , Andrey Vagin , James Bottomley , Glauber Costa , "H. Peter Anvin" , Ingo Molnar , Dave Hansen , "Eric W. Biederman" , Daniel Lezcano , Alexey Dobriyan , Linus Torvalds , Oleg Nesterov Subject: Re: [patch 5/5] elf: Add support for loading ET_CKPT files Message-ID: <20111021184817.GC28670@google.com> References: <20111014110416.552685686@openvz.org> <20111014110511.670174429@openvz.org> <20111014171033.GC4294@google.com> <20111014173304.GD4294@google.com> <4E9E9255.7090601@parallels.com> <20111019182228.GJ25124@google.com> <20111019195632.GB14464@moon> <20111021182610.GB28670@google.com> <20111021183628.GH31508@moon> <20111021184239.GI31508@moon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111021184239.GI31508@moon> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Fri, Oct 21, 2011 at 10:42:39PM +0400, Cyrill Gorcunov wrote: > On Fri, Oct 21, 2011 at 10:36:28PM +0400, Cyrill Gorcunov wrote: > > > I think this comes back to why one-stop-solution-in-kernel is a bad > > > idea for CR. My impression is that when people say "that would > > > require too many small API updatesa", it usually means that they > > > haven't really thought about each necessary piece enough and just > > Don't claim such things, Tejun. Yes, I'm missing a number of things > (the same applies to you as well), but this patch was not 'just a > fast way to achieve what we need'. It's rather an attempt to gather > all things I've missed and provide more robust/solid version at the > next iteration (regargless which form this patch appeared, complete > user-space solution, some kernel api extension of whatever). Hmmm... my point was that single lumpy implementation allows for such mistakes to go unnoticed && makes it difficult to recover and thus is a bad approach to the problem. For example, unlikely but, let's say we missed this vdso thing and it went into upstream, now what would we do? We'll need to somehow allow userland supply vdso symtab to kernel and let the kernel do the bridging and then probably bump the version number for elf format and so on. IMHO, that just isn't a good way to approach the problem, so let's please do it piece by piece. Thanks. -- tejun