linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jari Ruusu <jariruusu@users.sourceforge.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: kernel.org tarball/patch signature files
Date: Sun, 23 Oct 2011 13:37:27 +0200	[thread overview]
Message-ID: <20111023113727.GA24285@kroah.com> (raw)
In-Reply-To: <4EA3F7C0.24E469C5@users.sourceforge.net>

On Sun, Oct 23, 2011 at 02:17:20PM +0300, Jari Ruusu wrote:
> I noticed that patch-3.0.7.sign is a detached signature file for
> DECOMPRESSED patch-3.0.7.{bz2,gz,xz}.

That's exactly what I said in my announcement:
	https://lkml.org/lkml/2011/10/23/51
so I'm glad it's working properly :)

> Maybe this is not the best possible
> way to sign compressed tarballs/patches. This is because it places hell of
> lot of trust on quality/security of decompressor implementation.
> Historically decompressor implementations have had bugs and security flaws.
> It is stupid to assume that there won't be any more of them.
> 
> Wrong order to verify compressed tarball/patch:
> 
> (1) Feed potentially maliciously formatted data to decompressor, and exploit
>     any undiscovered/unpatched vulnerability in decompressor implementation.
> (2) Verify decompressed output.
> 
> Much better order would be:
> 
> (1) Verify compressed data.
> (2) Feed trusted data to decompressor.
> 
> So, would it be possible to have multiple signature files like this? Please.
> 
> patch-3.X.Y.bz2
> patch-3.X.Y.bz2.sign
> patch-3.X.Y.gz
> patch-3.X.Y.gz.sign
> patch-3.X.Y.xz
> patch-3.X.Y.xz.sign

Nope, sorry, let's try this way instead.  That way we only have to
generate one signature, not 3.

If you are really worried about decompressor bugs, then run them in a
virtual machine/chroot :)

greg k-h

  reply	other threads:[~2011-10-23 11:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-23 11:17 kernel.org tarball/patch signature files Jari Ruusu
2011-10-23 11:37 ` Greg KH [this message]
2011-10-23 14:07   ` Jari Ruusu
2011-10-25  1:49     ` Greg KH
2011-10-25  4:31       ` Kyle Moffett
2011-10-25  8:27         ` H. Peter Anvin
2011-10-25  9:13           ` Valdis.Kletnieks
2011-10-25  9:32             ` H. Peter Anvin
2011-10-25  6:06       ` Jari Ruusu
2011-10-25  7:09         ` Greg KH
2011-10-25  8:09           ` Jari Ruusu
2011-10-25  7:28       ` Valdis.Kletnieks
2011-10-25  7:34         ` Greg KH
2011-10-24 17:18   ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111023113727.GA24285@kroah.com \
    --to=greg@kroah.com \
    --cc=jariruusu@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).