From: "Leonid V. Fedorenchik" <leonidsbox@gmail.com>
To: "Palash Bandyopadhyay" <Palash.Bandyopadhyay@conexant.com>
Cc: "Greg Kroah-Hartman" <gregkh@suse.de>,
"Mauro Carvalho Chehab" <mchehab@redhat.com>,
"Namhyung Kim" <namhyung@gmail.com>,
"Joe Perches" <joe@perches.com>,
"Ilia Mirkin" <imirkin@alum.mit.edu>,
"Youquan Song" <youquan.song@intel.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/36] Staging: cx25821: Clean up patch series
Date: Sun, 23 Oct 2011 23:20:21 +0800 [thread overview]
Message-ID: <20111023232021.59f9c193@inspire> (raw)
In-Reply-To: <34B38BE41EDBA046A4AFBB591FA311320506CF35B4@NBMBX01.bbnet.ad>
On Sat, 22 Oct 2011 05:50:14 -0700
"Palash Bandyopadhyay" <Palash.Bandyopadhyay@conexant.com> wrote:
> Thanks Leonid!
>
> Change in patch #18 is also ok.
Thank you for review.
>
> Regards,
> Palash
>
> ________________________________________
> From: Leonid V. Fedorenchik [leonidsbox@gmail.com]
> Sent: Friday, October 21, 2011 10:43 PM
> To: Greg Kroah-Hartman
> Cc: Mauro Carvalho Chehab; Namhyung Kim; Palash Bandyopadhyay; Joe Perches; Ilia Mirkin; Youquan Song; Leonid V. Fedorenchik; devel@linuxdriverproject.org; linux-kernel@vger.kernel.org
> Subject: [PATCH 00/36] Staging: cx25821: Clean up patch series
>
> This patch series fixes some style issues in drivers/staging/cx25821
> Mostly I was hoping to improve readability and fix some issues found by
> checkpatch.pl script.
>
> There is one question, however, in patch no. 18:
> I deleted part of the comment that contradicts to the code and in this
> case maybe I should edit the code to match the comment instead. I am not
> sure if in this case it makes sense to check if width > 0.
>
> Leonid V. Fedorenchik (36):
> Staging: cx25821: cx25821-alsa.c: Line up comments
> Staging: cx25821: cx25821-alsa.c: Add braces to else clause
> Staging: cx25821: cx25821-alsa.c: Fix indent
> Staging: cx25821: cx25821-alsa.c: Change line endings
> Staging: cx25821: cx25821-audio-upstream.c: Fix indent
> Staging: cx25821: cx25821-audio-upstream.c: Move operators
> Staging: cx25821: cx25821-audio-upstream.c: Change line endings
> Staging: cx25821: cx25821-audio.h: Line up defines
> Staging: cx25821: cx25821-audio.h: Fix multiline defines
> Staging: cx25821: cx25821-cards.c: Fix indent
> Staging: cx25821: cx25821-core.c: Delete empty line
> Staging: cx25821: cx25821-core.c: Fix indent
> Staging: cx25821: cx25821-core.c: Change line endings
> Staging: cx25821: cx25821-i2c.c: Change line endings
> Staging: cx25821: cx25821-medusa-defines.h: Fix typo
> Staging: cx25821: cx25821-medusa-defines.h: Line up defines
> Staging: cx25821: cx25821-medusa-reg.h: Line up defines
> Staging: cx25821: cx25821-medusa-video.c: Fix comment
> Staging: cx25821: cx25821-medusa-video.c: Move operators
> Staging: cx25821: cx25821-medusa-video.c: Change line endings
> Staging: cx25821: cx25821-video-upstream-ch2.c: Line up comments
> Staging: cx25821: cx25821-video-upstream-ch2.c: Fix indent
> Staging: cx25821: cx25821-video-upsstream-ch2.c: Move operators
> Staging: cx25821: cx25821-video-upstream-ch2.c: Remove braces
> Staging: cx25821: cx25821-video-upstream-ch2.c: Change line endings
> Staging: cx25821: cx25821-video-upstream.c: Remove braces
> Staging: cx25821: cx25821-video-upstream.c: Fix indent
> Staging: cx25821: cx25821-video-upstream.c: Change line endings
> Staging: cx25821: cx25821-video.c: Delete empty line
> Staging: cx25821: cx25821-video.c: Change spaces
> Staging: cx25821: cx25821-video.c: Fix assignment
> Staging: cx25821: cx25821-video.c: Fix definitions
> Staging: cx25821: cx25821-video.c: Move operators
> Staging: cx25821: cx25821-video.c: Fix indent
> Staging: cx25821: cx25821-video.c: Change line endings
> Staging: cx25821: cx25821.h: Line up defines
>
> drivers/staging/cx25821/cx25821-alsa.c | 73 ++--
> drivers/staging/cx25821/cx25821-audio-upstream.c | 102 ++--
> drivers/staging/cx25821/cx25821-audio.h | 39 +-
> drivers/staging/cx25821/cx25821-cards.c | 2 +-
> drivers/staging/cx25821/cx25821-core.c | 57 +--
> drivers/staging/cx25821/cx25821-i2c.c | 10 +-
> drivers/staging/cx25821/cx25821-medusa-defines.h | 6 +-
> drivers/staging/cx25821/cx25821-medusa-reg.h | 518 ++++++++++----------
> drivers/staging/cx25821/cx25821-medusa-video.c | 410 ++++++----------
> .../staging/cx25821/cx25821-video-upstream-ch2.c | 126 ++---
> drivers/staging/cx25821/cx25821-video-upstream.c | 146 +++----
> drivers/staging/cx25821/cx25821-video.c | 145 +++---
> drivers/staging/cx25821/cx25821.h | 4 +-
> 13 files changed, 745 insertions(+), 893 deletions(-)
> Conexant E-mail Firewall (Conexant.Com) made the following annotations
> ---------------------------------------------------------------------
> ********************** Legal Disclaimer ****************************
>
> "This email may contain confidential and privileged material for the sole use of the intended recipient. Any unauthorized review, use or distribution by others is strictly prohibited. If you have received the message in error, please advise the sender by reply email and delete the message. Thank you."
>
> **********************************************************************
>
> ---------------------------------------------------------------------
>
Leonid V. Fedorenchik
prev parent reply other threads:[~2011-10-23 15:22 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-22 5:43 [PATCH 00/36] Staging: cx25821: Clean up patch series Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 01/36] Staging: cx25821: cx25821-alsa.c: Line up comments Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 02/36] Staging: cx25821: cx25821-alsa.c: Add braces to else clause Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 03/36] Staging: cx25821: cx25821-alsa.c: Fix indent Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 04/36] Staging: cx25821: cx25821-alsa.c: Change line endings Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 05/36] Staging: cx25821: cx25821-audio-upstream.c: Fix indent Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 06/36] Staging: cx25821: cx25821-audio-upstream.c: Move operators Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 07/36] Staging: cx25821: cx25821-audio-upstream.c: Change line endings Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 08/36] Staging: cx25821: cx25821-audio.h: Line up defines Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 09/36] Staging: cx25821: cx25821-audio.h: Fix multiline defines Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 10/36] Staging: cx25821: cx25821-cards.c: Fix indent Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 11/36] Staging: cx25821: cx25821-core.c: Delete empty line Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 12/36] Staging: cx25821: cx25821-core.c: Fix indent Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 13/36] Staging: cx25821: cx25821-core.c: Change line endings Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 14/36] Staging: cx25821: cx25821-i2c.c: " Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 15/36] Staging: cx25821: cx25821-medusa-defines.h: Fix typo Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 16/36] Staging: cx25821: cx25821-medusa-defines.h: Line up defines Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 17/36] Staging: cx25821: cx25821-medusa-reg.h: " Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 18/36] Staging: cx25821: cx25821-medusa-video.c: Fix comment Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 19/36] Staging: cx25821: cx25821-medusa-video.c: Move operators Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 20/36] Staging: cx25821: cx25821-medusa-video.c: Change line endings Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 21/36] Staging: cx25821: cx25821-video-upstream-ch2.c: Line up comments Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 22/36] Staging: cx25821: cx25821-video-upstream-ch2.c: Fix indent Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 23/36] Staging: cx25821: cx25821-video-upsstream-ch2.c: Move operators Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 24/36] Staging: cx25821: cx25821-video-upstream-ch2.c: Remove braces Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 25/36] Staging: cx25821: cx25821-video-upstream-ch2.c: Change line endings Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 26/36] Staging: cx25821: cx25821-video-upstream.c: Remove braces Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 27/36] Staging: cx25821: cx25821-video-upstream.c: Fix indent Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 28/36] Staging: cx25821: cx25821-video-upstream.c: Change line endings Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 29/36] Staging: cx25821: cx25821-video.c: Delete empty line Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 30/36] Staging: cx25821: cx25821-video.c: Change spaces Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 31/36] Staging: cx25821: cx25821-video.c: Fix assignment Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 32/36] Staging: cx25821: cx25821-video.c: Fix definitions Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 33/36] Staging: cx25821: cx25821-video.c: Move operators Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 34/36] Staging: cx25821: cx25821-video.c: Fix indent Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 35/36] Staging: cx25821: cx25821-video.c: Change line endings Leonid V. Fedorenchik
2011-10-22 5:43 ` [PATCH 36/36] Staging: cx25821: cx25821.h: Line up defines Leonid V. Fedorenchik
2011-10-22 8:19 ` [PATCH 00/36] Staging: cx25821: Clean up patch series Greg KH
2011-10-23 5:36 ` Mauro Carvalho Chehab
2011-10-23 15:24 ` Leonid V. Fedorenchik
2011-10-23 20:45 ` Mauro Carvalho Chehab
2011-10-24 14:46 ` Leonid V. Fedorenchik
2011-10-24 15:49 ` [PATCH] MAINTAINERS: Staging: cx25821: Add L: linux-media Joe Perches
2011-11-19 6:28 ` [PATCH 00/36] Staging: cx25821: Clean up patch series Leonid V. Fedorenchik
2011-11-24 20:42 ` Mauro Carvalho Chehab
2011-11-25 11:29 ` Leonid V. Fedorenchik
2011-10-22 12:50 ` Palash Bandyopadhyay
2011-10-23 15:20 ` Leonid V. Fedorenchik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111023232021.59f9c193@inspire \
--to=leonidsbox@gmail.com \
--cc=Palash.Bandyopadhyay@conexant.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@suse.de \
--cc=imirkin@alum.mit.edu \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=namhyung@gmail.com \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox