From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754557Ab1JXJnG (ORCPT ); Mon, 24 Oct 2011 05:43:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35082 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753966Ab1JXJnD (ORCPT ); Mon, 24 Oct 2011 05:43:03 -0400 Date: Mon, 24 Oct 2011 11:38:29 +0200 From: Greg KH To: Raghavendra K T Cc: Raghavendra K T , KVM , Konrad Rzeszutek Wilk , Sedat Dilek , Virtualization , Jeremy Fitzhardinge , x86@kernel.org, "H. Peter Anvin" , Dave Jiang , Thomas Gleixner , Stefano Stabellini , Gleb Natapov , Yinghai Lu , Marcelo Tosatti , Ingo Molnar , Avi Kivity , Rik van Riel , Xen , LKML , Suzuki Poulose , Srivatsa Vaddagiri , Peter Zijlstra Subject: Re: [PATCH RFC V2 2/5] debugfs: Renaming of xen functions and change unsigned to u32 Message-ID: <20111024093829.GA2214@suse.de> References: <20111023190307.16364.35381.sendpatchset@oc5400248562.ibm.com> <20111023190459.16364.98151.sendpatchset@oc5400248562.ibm.com> <20111023221920.GA591@suse.de> <4EA52FCF.2090508@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4EA52FCF.2090508@linux.vnet.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2011 at 02:58:47PM +0530, Raghavendra K T wrote: > On 10/24/2011 03:49 AM, Greg KH wrote: > >On Mon, Oct 24, 2011 at 12:34:59AM +0530, Raghavendra K T wrote: > >>Renaming of xen functions and change unsigned to u32. > > > >Why not just rename when you move the functions? Why the extra step? > > > Intention was only clarity. Yes, if this patch is an overhead, I 'll > combine both the patches. Yeah, it makes more sense as it originally confused me why you were adding a "xen_*" function to the debugfs core code :) thanks, greg k-h