linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: wm8400: Fix setting Fout clock divider for FLL Control 4
@ 2011-10-22 14:48 Axel Lin
  2011-10-24 12:04 ` Girdwood, Liam
  2011-10-24 12:08 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-10-22 14:48 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Brown, Dimitris Papastamos, Liam Girdwood, alsa-devel

What we want here is to clear the WM8400_FLL_OUTDIV_MASK bits then
OR with factors.outdiv.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 sound/soc/codecs/wm8400.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/wm8400.c b/sound/soc/codecs/wm8400.c
index dc13be2..f29bc26 100644
--- a/sound/soc/codecs/wm8400.c
+++ b/sound/soc/codecs/wm8400.c
@@ -1059,7 +1059,7 @@ static int wm8400_set_dai_pll(struct snd_soc_dai *codec_dai, int pll_id,
 	wm8400_write(codec, WM8400_FLL_CONTROL_3, factors.n);
 
 	reg = wm8400_read(codec, WM8400_FLL_CONTROL_4);
-	reg &= WM8400_FLL_OUTDIV_MASK;
+	reg &= ~WM8400_FLL_OUTDIV_MASK;
 	reg |= factors.outdiv;
 	wm8400_write(codec, WM8400_FLL_CONTROL_4, reg);
 
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: wm8400: Fix setting Fout clock divider for FLL Control 4
  2011-10-22 14:48 [PATCH] ASoC: wm8400: Fix setting Fout clock divider for FLL Control 4 Axel Lin
@ 2011-10-24 12:04 ` Girdwood, Liam
  2011-10-24 12:08 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Girdwood, Liam @ 2011-10-24 12:04 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Mark Brown, Dimitris Papastamos, alsa-devel

On 22 October 2011 15:48, Axel Lin <axel.lin@gmail.com> wrote:
> What we want here is to clear the WM8400_FLL_OUTDIV_MASK bits then
> OR with factors.outdiv.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  sound/soc/codecs/wm8400.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8400.c b/sound/soc/codecs/wm8400.c
> index dc13be2..f29bc26 100644
> --- a/sound/soc/codecs/wm8400.c
> +++ b/sound/soc/codecs/wm8400.c
> @@ -1059,7 +1059,7 @@ static int wm8400_set_dai_pll(struct snd_soc_dai *codec_dai, int pll_id,
>        wm8400_write(codec, WM8400_FLL_CONTROL_3, factors.n);
>
>        reg = wm8400_read(codec, WM8400_FLL_CONTROL_4);
> -       reg &= WM8400_FLL_OUTDIV_MASK;
> +       reg &= ~WM8400_FLL_OUTDIV_MASK;
>        reg |= factors.outdiv;
>        wm8400_write(codec, WM8400_FLL_CONTROL_4, reg);
>
> --
> 1.7.5.4
>
>
>
>

Acked-by: Liam Girdwood <lrg@ti.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: wm8400: Fix setting Fout clock divider for FLL Control 4
  2011-10-22 14:48 [PATCH] ASoC: wm8400: Fix setting Fout clock divider for FLL Control 4 Axel Lin
  2011-10-24 12:04 ` Girdwood, Liam
@ 2011-10-24 12:08 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-10-24 12:08 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Dimitris Papastamos, Liam Girdwood, alsa-devel

On Sat, Oct 22, 2011 at 10:48:27PM +0800, Axel Lin wrote:
> What we want here is to clear the WM8400_FLL_OUTDIV_MASK bits then
> OR with factors.outdiv.

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-10-24 12:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-22 14:48 [PATCH] ASoC: wm8400: Fix setting Fout clock divider for FLL Control 4 Axel Lin
2011-10-24 12:04 ` Girdwood, Liam
2011-10-24 12:08 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).