linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: wm8996: Avoid a redundant i2c_get_clientdata call in wm8996_i2c_remove
@ 2011-10-24  3:31 Axel Lin
  2011-10-24 12:04 ` Girdwood, Liam
  2011-10-24 12:08 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-10-24  3:31 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Brown, Dimitris Papastamos, Liam Girdwood, alsa-devel

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 sound/soc/codecs/wm8996.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c
index 645c980..32324c9 100644
--- a/sound/soc/codecs/wm8996.c
+++ b/sound/soc/codecs/wm8996.c
@@ -3144,7 +3144,7 @@ static __devexit int wm8996_i2c_remove(struct i2c_client *client)
 	snd_soc_unregister_codec(&client->dev);
 	if (wm8996->pdata.ldo_ena > 0)
 		gpio_free(wm8996->pdata.ldo_ena);
-	kfree(i2c_get_clientdata(client));
+	kfree(wm8996);
 	return 0;
 }
 
-- 
1.7.5.4




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: wm8996: Avoid a redundant i2c_get_clientdata call in wm8996_i2c_remove
  2011-10-24  3:31 [PATCH] ASoC: wm8996: Avoid a redundant i2c_get_clientdata call in wm8996_i2c_remove Axel Lin
@ 2011-10-24 12:04 ` Girdwood, Liam
  2011-10-24 12:08 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Girdwood, Liam @ 2011-10-24 12:04 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Mark Brown, Dimitris Papastamos, alsa-devel

On 24 October 2011 04:31, Axel Lin <axel.lin@gmail.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  sound/soc/codecs/wm8996.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8996.c b/sound/soc/codecs/wm8996.c
> index 645c980..32324c9 100644
> --- a/sound/soc/codecs/wm8996.c
> +++ b/sound/soc/codecs/wm8996.c
> @@ -3144,7 +3144,7 @@ static __devexit int wm8996_i2c_remove(struct i2c_client *client)
>        snd_soc_unregister_codec(&client->dev);
>        if (wm8996->pdata.ldo_ena > 0)
>                gpio_free(wm8996->pdata.ldo_ena);
> -       kfree(i2c_get_clientdata(client));
> +       kfree(wm8996);
>        return 0;
>  }
>

Acked-by: Liam Girdwood <lrg@ti.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: wm8996: Avoid a redundant i2c_get_clientdata call in wm8996_i2c_remove
  2011-10-24  3:31 [PATCH] ASoC: wm8996: Avoid a redundant i2c_get_clientdata call in wm8996_i2c_remove Axel Lin
  2011-10-24 12:04 ` Girdwood, Liam
@ 2011-10-24 12:08 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-10-24 12:08 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Dimitris Papastamos, Liam Girdwood, alsa-devel

On Mon, Oct 24, 2011 at 11:31:12AM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-10-24 12:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-24  3:31 [PATCH] ASoC: wm8996: Avoid a redundant i2c_get_clientdata call in wm8996_i2c_remove Axel Lin
2011-10-24 12:04 ` Girdwood, Liam
2011-10-24 12:08 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).