Re: [PATCH staging 6/6] et131x: uncloak PCIe capabilities.

Francois Romieu
2011-10-25T16:02:56Z

Mark Einon <mark.einon@gmail.com> :
[...]
> The PCIe changes are good, however I think using gotos here doesn't add
> anything as there's no difficult locking to navigate and makes the code
> harder to read.
> both out: and err_out: are used to return an error, and the backwards
> jumping goto makes me a bit uncomfortable. Could you respin with just the
> PCIe changes?

I confess I use a 55 lines vi split terminal when reviewing these blocks.

As there is no documentation to check the remaining PCIe candidate bits,
it's probably not worth it anyway.

--
Ueimor