* [PATCH] h8300: Move gpio.h to gpio-internal.h
@ 2011-10-24 21:59 Mark Brown
2011-10-24 22:10 ` Grant Likely
2011-10-25 5:55 ` Yoshinori Sato
0 siblings, 2 replies; 6+ messages in thread
From: Mark Brown @ 2011-10-24 21:59 UTC (permalink / raw)
To: Yoshinori Sato, Grant Likely; +Cc: linux-kernel, Mark Brown
The current h8300 GPIO implementation doesn't provide the standard GPIO
API, and in fact provides only direction control rather than normal GPIO
functionality. Currently this is only used by the platform interrupt
implementation rather than by a range of drivers so in preparation for
moving over to gpiolib move the header out of the way of the gpiolib
header, allowing a default GPIO implementation to be provided.
For actual use of these GPIOs with gpiolib a real driver would still need
to be written but there appears to be no current need for this.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
It might be best to merge this via the gpiolib tree, partly because
there appears to be little other activity on h8300 right now and partly
to allow further refactoring.
arch/h8300/include/asm/{gpio.h => gpio-internal.h} | 0
arch/h8300/platform/h8300h/irq.c | 2 +-
arch/h8300/platform/h8s/irq.c | 2 +-
3 files changed, 2 insertions(+), 2 deletions(-)
rename arch/h8300/include/asm/{gpio.h => gpio-internal.h} (100%)
diff --git a/arch/h8300/include/asm/gpio.h b/arch/h8300/include/asm/gpio-internal.h
similarity index 100%
rename from arch/h8300/include/asm/gpio.h
rename to arch/h8300/include/asm/gpio-internal.h
diff --git a/arch/h8300/platform/h8300h/irq.c b/arch/h8300/platform/h8300h/irq.c
index e977345..bc4f51b 100644
--- a/arch/h8300/platform/h8300h/irq.c
+++ b/arch/h8300/platform/h8300h/irq.c
@@ -11,7 +11,7 @@
#include <asm/traps.h>
#include <asm/irq.h>
#include <asm/io.h>
-#include <asm/gpio.h>
+#include <asm/gpio-internal.h>
#include <asm/regs306x.h>
const int __initdata h8300_saved_vectors[] = {
diff --git a/arch/h8300/platform/h8s/irq.c b/arch/h8300/platform/h8s/irq.c
index 8182f04..7b5f29f 100644
--- a/arch/h8300/platform/h8s/irq.c
+++ b/arch/h8300/platform/h8s/irq.c
@@ -14,7 +14,7 @@
#include <asm/traps.h>
#include <asm/irq.h>
#include <asm/io.h>
-#include <asm/gpio.h>
+#include <asm/gpio-internal.h>
#include <asm/regs267x.h>
/* saved vector list */
--
1.7.6.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] h8300: Move gpio.h to gpio-internal.h
2011-10-24 21:59 [PATCH] h8300: Move gpio.h to gpio-internal.h Mark Brown
@ 2011-10-24 22:10 ` Grant Likely
2011-10-24 22:32 ` Mark Brown
2011-10-25 5:55 ` Yoshinori Sato
1 sibling, 1 reply; 6+ messages in thread
From: Grant Likely @ 2011-10-24 22:10 UTC (permalink / raw)
To: Mark Brown; +Cc: Yoshinori Sato, Grant Likely, linux-kernel
On Mon, Oct 24, 2011 at 11:59:21PM +0200, Mark Brown wrote:
> The current h8300 GPIO implementation doesn't provide the standard GPIO
> API, and in fact provides only direction control rather than normal GPIO
> functionality. Currently this is only used by the platform interrupt
> implementation rather than by a range of drivers so in preparation for
> moving over to gpiolib move the header out of the way of the gpiolib
> header, allowing a default GPIO implementation to be provided.
>
> For actual use of these GPIOs with gpiolib a real driver would still need
> to be written but there appears to be no current need for this.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
This of course should go via the h8300 tree instead of the gpio tree.
g.
> ---
>
> It might be best to merge this via the gpiolib tree, partly because
> there appears to be little other activity on h8300 right now and partly
> to allow further refactoring.
>
> arch/h8300/include/asm/{gpio.h => gpio-internal.h} | 0
> arch/h8300/platform/h8300h/irq.c | 2 +-
> arch/h8300/platform/h8s/irq.c | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename arch/h8300/include/asm/{gpio.h => gpio-internal.h} (100%)
>
> diff --git a/arch/h8300/include/asm/gpio.h b/arch/h8300/include/asm/gpio-internal.h
> similarity index 100%
> rename from arch/h8300/include/asm/gpio.h
> rename to arch/h8300/include/asm/gpio-internal.h
> diff --git a/arch/h8300/platform/h8300h/irq.c b/arch/h8300/platform/h8300h/irq.c
> index e977345..bc4f51b 100644
> --- a/arch/h8300/platform/h8300h/irq.c
> +++ b/arch/h8300/platform/h8300h/irq.c
> @@ -11,7 +11,7 @@
> #include <asm/traps.h>
> #include <asm/irq.h>
> #include <asm/io.h>
> -#include <asm/gpio.h>
> +#include <asm/gpio-internal.h>
> #include <asm/regs306x.h>
>
> const int __initdata h8300_saved_vectors[] = {
> diff --git a/arch/h8300/platform/h8s/irq.c b/arch/h8300/platform/h8s/irq.c
> index 8182f04..7b5f29f 100644
> --- a/arch/h8300/platform/h8s/irq.c
> +++ b/arch/h8300/platform/h8s/irq.c
> @@ -14,7 +14,7 @@
> #include <asm/traps.h>
> #include <asm/irq.h>
> #include <asm/io.h>
> -#include <asm/gpio.h>
> +#include <asm/gpio-internal.h>
> #include <asm/regs267x.h>
>
> /* saved vector list */
> --
> 1.7.6.3
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] h8300: Move gpio.h to gpio-internal.h
2011-10-24 22:10 ` Grant Likely
@ 2011-10-24 22:32 ` Mark Brown
2011-10-24 22:40 ` Grant Likely
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2011-10-24 22:32 UTC (permalink / raw)
To: Grant Likely; +Cc: Yoshinori Sato, Grant Likely, linux-kernel
On Tue, Oct 25, 2011 at 12:10:04AM +0200, Grant Likely wrote:
> This of course should go via the h8300 tree instead of the gpio tree.
If you look at the commit history there's not been much h8300 specific
work going on for quite some time now - all the commits have been going
via other trees - so since it's basically a gpiolib cleanup I figure
it'd be less work for Sato-san if you were able to pick it up.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] h8300: Move gpio.h to gpio-internal.h
2011-10-24 22:32 ` Mark Brown
@ 2011-10-24 22:40 ` Grant Likely
0 siblings, 0 replies; 6+ messages in thread
From: Grant Likely @ 2011-10-24 22:40 UTC (permalink / raw)
To: Mark Brown; +Cc: Yoshinori Sato, Grant Likely, linux-kernel
On Tue, Oct 25, 2011 at 12:32 AM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Oct 25, 2011 at 12:10:04AM +0200, Grant Likely wrote:
>
>> This of course should go via the h8300 tree instead of the gpio tree.
>
> If you look at the commit history there's not been much h8300 specific
> work going on for quite some time now - all the commits have been going
> via other trees - so since it's basically a gpiolib cleanup I figure
> it'd be less work for Sato-san if you were able to pick it up.
Okay, will do.
g.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] h8300: Move gpio.h to gpio-internal.h
2011-10-24 21:59 [PATCH] h8300: Move gpio.h to gpio-internal.h Mark Brown
2011-10-24 22:10 ` Grant Likely
@ 2011-10-25 5:55 ` Yoshinori Sato
2011-10-25 7:08 ` Mark Brown
1 sibling, 1 reply; 6+ messages in thread
From: Yoshinori Sato @ 2011-10-25 5:55 UTC (permalink / raw)
To: Mark Brown; +Cc: Grant Likely, linux-kernel
At Mon, 24 Oct 2011 23:59:21 +0200,
Mark Brown wrote:
>
> The current h8300 GPIO implementation doesn't provide the standard GPIO
> API, and in fact provides only direction control rather than normal GPIO
> functionality. Currently this is only used by the platform interrupt
> implementation rather than by a range of drivers so in preparation for
> moving over to gpiolib move the header out of the way of the gpiolib
> header, allowing a default GPIO implementation to be provided.
>
> For actual use of these GPIOs with gpiolib a real driver would still need
> to be written but there appears to be no current need for this.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Yoshinori Sato <ysato@users.sourceforge.jp>
I will moving generic GPIO.
> ---
>
> It might be best to merge this via the gpiolib tree, partly because
> there appears to be little other activity on h8300 right now and partly
> to allow further refactoring.
>
> arch/h8300/include/asm/{gpio.h => gpio-internal.h} | 0
> arch/h8300/platform/h8300h/irq.c | 2 +-
> arch/h8300/platform/h8s/irq.c | 2 +-
> 3 files changed, 2 insertions(+), 2 deletions(-)
> rename arch/h8300/include/asm/{gpio.h => gpio-internal.h} (100%)
>
> diff --git a/arch/h8300/include/asm/gpio.h b/arch/h8300/include/asm/gpio-internal.h
> similarity index 100%
> rename from arch/h8300/include/asm/gpio.h
> rename to arch/h8300/include/asm/gpio-internal.h
> diff --git a/arch/h8300/platform/h8300h/irq.c b/arch/h8300/platform/h8300h/irq.c
> index e977345..bc4f51b 100644
> --- a/arch/h8300/platform/h8300h/irq.c
> +++ b/arch/h8300/platform/h8300h/irq.c
> @@ -11,7 +11,7 @@
> #include <asm/traps.h>
> #include <asm/irq.h>
> #include <asm/io.h>
> -#include <asm/gpio.h>
> +#include <asm/gpio-internal.h>
> #include <asm/regs306x.h>
>
> const int __initdata h8300_saved_vectors[] = {
> diff --git a/arch/h8300/platform/h8s/irq.c b/arch/h8300/platform/h8s/irq.c
> index 8182f04..7b5f29f 100644
> --- a/arch/h8300/platform/h8s/irq.c
> +++ b/arch/h8300/platform/h8s/irq.c
> @@ -14,7 +14,7 @@
> #include <asm/traps.h>
> #include <asm/irq.h>
> #include <asm/io.h>
> -#include <asm/gpio.h>
> +#include <asm/gpio-internal.h>
> #include <asm/regs267x.h>
>
> /* saved vector list */
> --
> 1.7.6.3
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] h8300: Move gpio.h to gpio-internal.h
2011-10-25 5:55 ` Yoshinori Sato
@ 2011-10-25 7:08 ` Mark Brown
0 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2011-10-25 7:08 UTC (permalink / raw)
To: Yoshinori Sato; +Cc: Grant Likely, linux-kernel
On Tue, Oct 25, 2011 at 02:55:51PM +0900, Yoshinori Sato wrote:
> I will moving generic GPIO.
Excellent news! I'm hoping this week to post some further patches which
make this a little easier by making a default version of asm/gpio.h
available. Hopefully we'll also be able to turn on optional gpiolib
support for all architectures which should mean that all that's required
is a new driver for the CPU under drivers/gpio.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-10-25 7:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-24 21:59 [PATCH] h8300: Move gpio.h to gpio-internal.h Mark Brown
2011-10-24 22:10 ` Grant Likely
2011-10-24 22:32 ` Mark Brown
2011-10-24 22:40 ` Grant Likely
2011-10-25 5:55 ` Yoshinori Sato
2011-10-25 7:08 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).