* [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
@ 2011-10-24 22:38 Jesper Juhl
2011-10-24 22:42 ` Joe Perches
0 siblings, 1 reply; 14+ messages in thread
From: Jesper Juhl @ 2011-10-24 22:38 UTC (permalink / raw)
To: linux-scsi; +Cc: linux-kernel, James E.J. Bottomley, Anil Ravindranath
The first argument to kmalloc() is the size, the second is
flags. pmcraid_chr_ioctl() gets this wrong and swaps the
arguments. This patch corrects the mistake.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/scsi/pmcraid.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
compile tested only.
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index d079f9a..da19bdf 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4103,7 +4103,7 @@ static long pmcraid_chr_ioctl(
struct pmcraid_ioctl_header *hdr = NULL;
int retval = -ENOTTY;
- hdr = kmalloc(GFP_KERNEL, sizeof(struct pmcraid_ioctl_header));
+ hdr = kmalloc(sizeof(struct pmcraid_ioctl_header), GFP_KERNEL);
if (!hdr) {
pmcraid_err("faile to allocate memory for ioctl header\n");
--
1.7.7
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 22:38 [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl() Jesper Juhl
@ 2011-10-24 22:42 ` Joe Perches
2011-10-24 22:50 ` richard -rw- weinberger
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Joe Perches @ 2011-10-24 22:42 UTC (permalink / raw)
To: Jesper Juhl
Cc: linux-scsi, linux-kernel, James E.J. Bottomley, Anil Ravindranath
On Tue, 2011-10-25 at 00:38 +0200, Jesper Juhl wrote:
> The first argument to kmalloc() is the size, the second is
> flags. pmcraid_chr_ioctl() gets this wrong and swaps the
> arguments. This patch corrects the mistake.
>
> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> ---
> drivers/scsi/pmcraid.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> compile tested only.
>
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> index d079f9a..da19bdf 100644
> --- a/drivers/scsi/pmcraid.c
> +++ b/drivers/scsi/pmcraid.c
> @@ -4103,7 +4103,7 @@ static long pmcraid_chr_ioctl(
> struct pmcraid_ioctl_header *hdr = NULL;
> int retval = -ENOTTY;
>
> - hdr = kmalloc(GFP_KERNEL, sizeof(struct pmcraid_ioctl_header));
> + hdr = kmalloc(sizeof(struct pmcraid_ioctl_header), GFP_KERNEL);
>
> if (!hdr) {
> pmcraid_err("faile to allocate memory for ioctl header\n");
> --
> 1.7.7
>
>
James seems to be uninterested in picking up
obvious and trivially correct patches.
>From a year ago...
https://lkml.org/lkml/2010/10/31/123
James?
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 22:42 ` Joe Perches
@ 2011-10-24 22:50 ` richard -rw- weinberger
2011-10-24 22:54 ` Dave Jones
2011-10-24 22:57 ` Jesper Juhl
2011-10-24 22:51 ` Jesper Juhl
2011-10-24 23:18 ` Dave Jones
2 siblings, 2 replies; 14+ messages in thread
From: richard -rw- weinberger @ 2011-10-24 22:50 UTC (permalink / raw)
To: Joe Perches
Cc: Jesper Juhl, linux-scsi, linux-kernel, James E.J. Bottomley,
Anil Ravindranath, davej
On Tue, Oct 25, 2011 at 12:42 AM, Joe Perches <joe@perches.com> wrote:
> On Tue, 2011-10-25 at 00:38 +0200, Jesper Juhl wrote:
>> The first argument to kmalloc() is the size, the second is
>> flags. pmcraid_chr_ioctl() gets this wrong and swaps the
>> arguments. This patch corrects the mistake.
>>
>> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
>> ---
>> drivers/scsi/pmcraid.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> compile tested only.
>>
>> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
>> index d079f9a..da19bdf 100644
>> --- a/drivers/scsi/pmcraid.c
>> +++ b/drivers/scsi/pmcraid.c
>> @@ -4103,7 +4103,7 @@ static long pmcraid_chr_ioctl(
>> struct pmcraid_ioctl_header *hdr = NULL;
>> int retval = -ENOTTY;
>>
>> - hdr = kmalloc(GFP_KERNEL, sizeof(struct pmcraid_ioctl_header));
>> + hdr = kmalloc(sizeof(struct pmcraid_ioctl_header), GFP_KERNEL);
>>
>> if (!hdr) {
>> pmcraid_err("faile to allocate memory for ioctl header\n");
>> --
>> 1.7.7
>>
>>
>
> James seems to be uninterested in picking up
> obvious and trivially correct patches.
>
BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
We could grep for "k[mzc]alloc(GFP_".
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 22:50 ` richard -rw- weinberger
@ 2011-10-24 22:54 ` Dave Jones
2011-10-24 23:03 ` richard -rw- weinberger
2011-10-24 23:06 ` Jesper Juhl
2011-10-24 22:57 ` Jesper Juhl
1 sibling, 2 replies; 14+ messages in thread
From: Dave Jones @ 2011-10-24 22:54 UTC (permalink / raw)
To: richard -rw- weinberger
Cc: Joe Perches, Jesper Juhl, linux-scsi, linux-kernel,
James E.J. Bottomley, Anil Ravindranath
On Tue, Oct 25, 2011 at 12:50:08AM +0200, richard -rw- weinberger wrote:
> BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
> We could grep for "k[mzc]alloc(GFP_".
Make sure to ignore bio_kmalloc (which has reverse argument order to kmalloc, ugh)
Dave
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 22:54 ` Dave Jones
@ 2011-10-24 23:03 ` richard -rw- weinberger
2011-10-24 23:13 ` Jesper Juhl
2011-10-24 23:06 ` Jesper Juhl
1 sibling, 1 reply; 14+ messages in thread
From: richard -rw- weinberger @ 2011-10-24 23:03 UTC (permalink / raw)
To: Dave Jones, richard -rw- weinberger, Joe Perches, Jesper Juhl,
linux-scsi, linux-kernel, James E.J. Bottomley, Anil Ravindranath
On Tue, Oct 25, 2011 at 12:54 AM, Dave Jones <davej@redhat.com> wrote:
> On Tue, Oct 25, 2011 at 12:50:08AM +0200, richard -rw- weinberger wrote:
>
> > BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
> > We could grep for "k[mzc]alloc(GFP_".
>
> Make sure to ignore bio_kmalloc (which has reverse argument order to kmalloc, ugh)
>
Hmmm, maybe we should "fix" the argument order of bio_kmalloc().
But as this function is exported we'd silently break some out-of-tree
kernel modules....
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 23:03 ` richard -rw- weinberger
@ 2011-10-24 23:13 ` Jesper Juhl
0 siblings, 0 replies; 14+ messages in thread
From: Jesper Juhl @ 2011-10-24 23:13 UTC (permalink / raw)
To: richard -rw- weinberger
Cc: Dave Jones, Joe Perches, linux-scsi, linux-kernel,
James E.J. Bottomley
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1193 bytes --]
On Tue, 25 Oct 2011, richard -rw- weinberger wrote:
> On Tue, Oct 25, 2011 at 12:54 AM, Dave Jones <davej@redhat.com> wrote:
> > On Tue, Oct 25, 2011 at 12:50:08AM +0200, richard -rw- weinberger wrote:
> >
> > > BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
> > > We could grep for "k[mzc]alloc(GFP_".
> >
> > Make sure to ignore bio_kmalloc (which has reverse argument order to kmalloc, ugh)
> >
>
> Hmmm, maybe we should "fix" the argument order of bio_kmalloc().
> But as this function is exported we'd silently break some out-of-tree
> kernel modules....
>
Or we could fix it noisily by renaming the function kmalloc_bio() and
fixing the argument order. That will still break out-of-tree modules, but
at least it won't break them silently...
Or we could introduce kmalloc_bio() with fixed argument order, fix all
in-kernel users and mark bio_kmalloc() deprecated with a note that it'll
go away by 3.6 or thereabouts...
I'd be happy to prepare a patch series doing that if it's wanted...?
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 22:54 ` Dave Jones
2011-10-24 23:03 ` richard -rw- weinberger
@ 2011-10-24 23:06 ` Jesper Juhl
1 sibling, 0 replies; 14+ messages in thread
From: Jesper Juhl @ 2011-10-24 23:06 UTC (permalink / raw)
To: Dave Jones
Cc: richard -rw- weinberger, Joe Perches, linux-scsi, linux-kernel,
James E.J. Bottomley
On Mon, 24 Oct 2011, Dave Jones wrote:
> On Tue, Oct 25, 2011 at 12:50:08AM +0200, richard -rw- weinberger wrote:
>
> > BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
> > We could grep for "k[mzc]alloc(GFP_".
>
> Make sure to ignore bio_kmalloc (which has reverse argument order to kmalloc, ugh)
>
Yeah, and there's also kmalloc_node() (and perhaps kmem_cache_alloc() &&
kmem_cache_alloc_node() although there the compiler will at least warn)
that might as well be checked for.
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 22:50 ` richard -rw- weinberger
2011-10-24 22:54 ` Dave Jones
@ 2011-10-24 22:57 ` Jesper Juhl
2011-10-24 23:07 ` Joe Perches
1 sibling, 1 reply; 14+ messages in thread
From: Jesper Juhl @ 2011-10-24 22:57 UTC (permalink / raw)
To: richard -rw- weinberger
Cc: Joe Perches, linux-scsi, linux-kernel, James E.J. Bottomley,
Anil Ravindranath, davej
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1696 bytes --]
On Tue, 25 Oct 2011, richard -rw- weinberger wrote:
> On Tue, Oct 25, 2011 at 12:42 AM, Joe Perches <joe@perches.com> wrote:
> > On Tue, 2011-10-25 at 00:38 +0200, Jesper Juhl wrote:
> >> The first argument to kmalloc() is the size, the second is
> >> flags. pmcraid_chr_ioctl() gets this wrong and swaps the
> >> arguments. This patch corrects the mistake.
> >>
> >> Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> >> ---
> >> drivers/scsi/pmcraid.c | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> compile tested only.
> >>
> >> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> >> index d079f9a..da19bdf 100644
> >> --- a/drivers/scsi/pmcraid.c
> >> +++ b/drivers/scsi/pmcraid.c
> >> @@ -4103,7 +4103,7 @@ static long pmcraid_chr_ioctl(
> >> struct pmcraid_ioctl_header *hdr = NULL;
> >> int retval = -ENOTTY;
> >>
> >> - hdr = kmalloc(GFP_KERNEL, sizeof(struct pmcraid_ioctl_header));
> >> + hdr = kmalloc(sizeof(struct pmcraid_ioctl_header), GFP_KERNEL);
> >>
> >> if (!hdr) {
> >> pmcraid_err("faile to allocate memory for ioctl header\n");
> >> --
> >> 1.7.7
> >>
> >>
> >
> > James seems to be uninterested in picking up
> > obvious and trivially correct patches.
> >
>
> BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
> We could grep for "k[mzc]alloc(GFP_".
>
I like that idea. That's exactely how I find these; by doing
egrep -R "[kv][mcz]alloc *\( *GFP_"
on the source tree.
Might as well be in checkpatch.pl
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 22:57 ` Jesper Juhl
@ 2011-10-24 23:07 ` Joe Perches
0 siblings, 0 replies; 14+ messages in thread
From: Joe Perches @ 2011-10-24 23:07 UTC (permalink / raw)
To: Jesper Juhl
Cc: richard -rw- weinberger, linux-scsi, linux-kernel,
James E.J. Bottomley, Anil Ravindranath, davej
On Tue, 2011-10-25 at 00:57 +0200, Jesper Juhl wrote:
> On Tue, 25 Oct 2011, richard -rw- weinberger wrote:
> > On Tue, Oct 25, 2011 at 12:42 AM, Joe Perches <joe@perches.com> wrote:
> > > On Tue, 2011-10-25 at 00:38 +0200, Jesper Juhl wrote:
> > BTW: What about a checkpatch.pl rule to detect such a misuse of kmalloc()?
> > We could grep for "k[mzc]alloc(GFP_".
> >
> I like that idea. That's exactely how I find these; by doing
> egrep -R "[kv][mcz]alloc *\( *GFP_"
> on the source tree.
> Might as well be in checkpatch.pl
Well, also from a year ago...
https://lkml.org/lkml/2010/10/31/121
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 22:42 ` Joe Perches
2011-10-24 22:50 ` richard -rw- weinberger
@ 2011-10-24 22:51 ` Jesper Juhl
2011-10-24 23:17 ` Joe Perches
2011-10-24 23:18 ` Dave Jones
2 siblings, 1 reply; 14+ messages in thread
From: Jesper Juhl @ 2011-10-24 22:51 UTC (permalink / raw)
To: Joe Perches
Cc: linux-scsi, linux-kernel, James E.J. Bottomley, Anil Ravindranath
On Mon, 24 Oct 2011, Joe Perches wrote:
> On Tue, 2011-10-25 at 00:38 +0200, Jesper Juhl wrote:
> > The first argument to kmalloc() is the size, the second is
> > flags. pmcraid_chr_ioctl() gets this wrong and swaps the
> > arguments. This patch corrects the mistake.
> >
> > Signed-off-by: Jesper Juhl <jj@chaosbits.net>
> > ---
> > drivers/scsi/pmcraid.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > compile tested only.
> >
> > diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
> > index d079f9a..da19bdf 100644
> > --- a/drivers/scsi/pmcraid.c
> > +++ b/drivers/scsi/pmcraid.c
> > @@ -4103,7 +4103,7 @@ static long pmcraid_chr_ioctl(
> > struct pmcraid_ioctl_header *hdr = NULL;
> > int retval = -ENOTTY;
> >
> > - hdr = kmalloc(GFP_KERNEL, sizeof(struct pmcraid_ioctl_header));
> > + hdr = kmalloc(sizeof(struct pmcraid_ioctl_header), GFP_KERNEL);
> >
> > if (!hdr) {
> > pmcraid_err("faile to allocate memory for ioctl header\n");
> > --
> > 1.7.7
> >
> >
>
> James seems to be uninterested in picking up
> obvious and trivially correct patches.
>
I've been getting that impression as well..
For example:
http://git.kernel.org/?p=linux/kernel/git/next/linux-next-history.git;a=commitdiff;h=2abe1b25e56b7c8e65f101fb22282dafeb5ec4ef
which I've been sumbitting numerous times over a long period of time
(these days akpm has picked it up and sends it on repeatedly, so I don't
really bother myself any more)...
> >From a year ago...
>
> https://lkml.org/lkml/2010/10/31/123
>
Ok, so you obviously got there first and your patch should be merged
rather than mine. I was not aware of that.
> James?
>
?
--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 22:51 ` Jesper Juhl
@ 2011-10-24 23:17 ` Joe Perches
0 siblings, 0 replies; 14+ messages in thread
From: Joe Perches @ 2011-10-24 23:17 UTC (permalink / raw)
To: Jesper Juhl; +Cc: linux-scsi, linux-kernel, James E.J. Bottomley, Andrew Morton
On Tue, 2011-10-25 at 00:51 +0200, Jesper Juhl wrote:
> On Mon, 24 Oct 2011, Joe Perches wrote:
> > On Tue, 2011-10-25 at 00:38 +0200, Jesper Juhl wrote:
> > > The first argument to kmalloc() is the size, the second is
> > > flags. pmcraid_chr_ioctl() gets this wrong and swaps the
> > > arguments. This patch corrects the mistake.
[]
> > James seems to be uninterested in picking up
> > obvious and trivially correct patches.
> I've been getting that impression as well..
> For example:
> http://git.kernel.org/?p=linux/kernel/git/next/linux-next-history.git;a=commitdiff;h=2abe1b25e56b7c8e65f101fb22282dafeb5ec4ef
> which I've been sumbitting numerous times over a long period of time
> (these days akpm has picked it up and sends it on repeatedly, so I don't
> really bother myself any more)...
> > >From a year ago...
> > https://lkml.org/lkml/2010/10/31/123
> Ok, so you obviously got there first
That doesn't matter at all to me.
What matters is getting the defects fixed
and not dropping patches on the floor.
Maybe that means there should be a different
or an additional scsi maintainer.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 22:42 ` Joe Perches
2011-10-24 22:50 ` richard -rw- weinberger
2011-10-24 22:51 ` Jesper Juhl
@ 2011-10-24 23:18 ` Dave Jones
2011-10-24 23:24 ` richard -rw- weinberger
2 siblings, 1 reply; 14+ messages in thread
From: Dave Jones @ 2011-10-24 23:18 UTC (permalink / raw)
To: Joe Perches; +Cc: Jesper Juhl, linux-scsi, linux-kernel, James E.J. Bottomley
On Mon, Oct 24, 2011 at 03:42:29PM -0700, Joe Perches wrote:
> James seems to be uninterested in picking up
> obvious and trivially correct patches.
>
> >From a year ago...
>
> https://lkml.org/lkml/2010/10/31/123
>
> James?
That's just ridiculous.
If maintainers aren't picking up obviously correct fixes[*], just send
them directly to Linus or Andrew.
Dave
[*] Functional changes only, not janitor stuff. Just the patches fixing
actual bugs.
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 23:18 ` Dave Jones
@ 2011-10-24 23:24 ` richard -rw- weinberger
2011-10-25 1:10 ` Joe Perches
0 siblings, 1 reply; 14+ messages in thread
From: richard -rw- weinberger @ 2011-10-24 23:24 UTC (permalink / raw)
To: Dave Jones, Joe Perches, Jesper Juhl, linux-scsi, linux-kernel,
James E.J. Bottomley
On Tue, Oct 25, 2011 at 1:18 AM, Dave Jones <davej@redhat.com> wrote:
> On Mon, Oct 24, 2011 at 03:42:29PM -0700, Joe Perches wrote:
> > James seems to be uninterested in picking up
> > obvious and trivially correct patches.
> >
> > >From a year ago...
> >
> > https://lkml.org/lkml/2010/10/31/123
> >
> > James?
>
> That's just ridiculous.
> If maintainers aren't picking up obviously correct fixes[*], just send
> them directly to Linus or Andrew.
>
Or resend the patch.
Sometimes maintainers are quite busy and overlook a patch...
--
Thanks,
//richard
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl()
2011-10-24 23:24 ` richard -rw- weinberger
@ 2011-10-25 1:10 ` Joe Perches
0 siblings, 0 replies; 14+ messages in thread
From: Joe Perches @ 2011-10-25 1:10 UTC (permalink / raw)
To: richard -rw- weinberger
Cc: Dave Jones, Jesper Juhl, linux-scsi, linux-kernel,
James E.J. Bottomley
On Tue, 2011-10-25 at 01:24 +0200, richard -rw- weinberger wrote:
> On Tue, Oct 25, 2011 at 1:18 AM, Dave Jones <davej@redhat.com> wrote:
> > On Mon, Oct 24, 2011 at 03:42:29PM -0700, Joe Perches wrote:
> > > James seems to be uninterested in picking up
> > > obvious and trivially correct patches.
> > > >From a year ago...
> > > https://lkml.org/lkml/2010/10/31/123
> > > James?
> > That's just ridiculous.
> > If maintainers aren't picking up obviously correct fixes[*], just send
> > them directly to Linus or Andrew.
> Or resend the patch.
I resent it too.
> Sometimes maintainers are quite busy and overlook a patch...
Or are perhaps just uninterested.
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2011-10-25 1:10 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-24 22:38 [PATCH] SCSI, pmcraid: Fix kmalloc() argument order in pmcraid_chr_ioctl() Jesper Juhl
2011-10-24 22:42 ` Joe Perches
2011-10-24 22:50 ` richard -rw- weinberger
2011-10-24 22:54 ` Dave Jones
2011-10-24 23:03 ` richard -rw- weinberger
2011-10-24 23:13 ` Jesper Juhl
2011-10-24 23:06 ` Jesper Juhl
2011-10-24 22:57 ` Jesper Juhl
2011-10-24 23:07 ` Joe Perches
2011-10-24 22:51 ` Jesper Juhl
2011-10-24 23:17 ` Joe Perches
2011-10-24 23:18 ` Dave Jones
2011-10-24 23:24 ` richard -rw- weinberger
2011-10-25 1:10 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox