Re: [PATCH] module,bug: Add TAINT_OOT_MODULE flag for modules not built in-tree

Ben Hutchings
2011-10-25T09:53:15Z

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

On Tue, 2011-10-25 at 14:26 +1030, Rusty Russell wrote:
> On Mon, 24 Oct 2011 07:57:03 -0700, Randy Dunlap <rdunlap@xenotime.net> wrote:
> > On 10/24/11 06:12, Ben Hutchings wrote:
> > > Use of the GPL or a compatible licence doesn't necessarily make the code
> > > any good. We already consider staging modules to be suspect, and this
> > > should also be true for out-of-tree modules which may receive very
> > > little review.
> > >
> > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > ---
> > > Debian has been carrying this for the last few kernel versions. The
> > > recent thread '[RFC] virtualbox tainting.' and discussions at KS suggest
> > > that this might be more generally useful.
> > >
> > > Ben.
> > >
> > > include/linux/kernel.h | 1 +
> > > kernel/module.c | 5 +++++
> > > kernel/panic.c | 2 ++
> > > scripts/mod/modpost.c | 7 +++++++
> > > 4 files changed, 15 insertions(+), 0 deletions(-)
> >
> > Hi,
> >
> > Please add 'O' to Documentation/oops-tracing.txt.

Sorry, this is the second time I've missed that now...

> I did that, and applied the patch. See below.
[...]

Thanks to everyone.

Ben.

--
Ben Hutchings
DNRC Motto: I can please only one person per day.
Today is not your day. Tomorrow isn't looking good either.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]